BIND 10 trac2497, updated. e3afa9c5286228971db62ff868785602e90a5513 [2497] Add tests for NSEC3, NSEC and TSIG rrtypes

[BIND 10 source code commits]

The branch, trac2497 has been updated
       via  e3afa9c5286228971db62ff868785602e90a5513 (commit)
      from  c73280d2ebe15512cd4f09ddbb28c2f5030cd86f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e3afa9c5286228971db62ff868785602e90a5513
Author: Mukund Sivaraman <muks at isc.org>
Date:   Fri Nov 30 17:42:39 2012 +0530

    [2497] Add tests for NSEC3, NSEC and TSIG rrtypes

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dns/tests/rdata_nsec3_unittest.cc |   14 ++++++++++++++
 src/lib/dns/tests/rdata_nsec_unittest.cc  |   13 +++++++++++++
 src/lib/dns/tests/rdata_tsig_unittest.cc  |   12 ++++++++++++
 3 files changed, 39 insertions(+)

-----------------------------------------------------------------------
diff --git a/src/lib/dns/tests/rdata_nsec3_unittest.cc b/src/lib/dns/tests/rdata_nsec3_unittest.cc
index edd2d4b..c7ca93e 100644
--- a/src/lib/dns/tests/rdata_nsec3_unittest.cc
+++ b/src/lib/dns/tests/rdata_nsec3_unittest.cc
@@ -130,6 +130,20 @@ TEST_F(Rdata_NSEC3_Test, createFromWire) {
     }
 }
 
+TEST_F(Rdata_NSEC3_Test, createFromLexer) {
+    const generic::NSEC3 rdata_nsec3(nsec3_txt);
+    EXPECT_EQ(0, rdata_nsec3.compare(
+        *test::createRdataUsingLexer(RRType::NSEC3(), RRClass::IN(),
+                                     nsec3_txt)));
+
+    // Check that bad input throws as usual (next hash shouldn't be
+    // padded)
+    EXPECT_THROW({
+        *test::createRdataUsingLexer(RRType::NSEC3(), RRClass::IN(),
+                                     "1 1 1 ADDAFEEE CPNMU=== A NS SOA");
+    }, InvalidRdataText);
+}
+
 TEST_F(Rdata_NSEC3_Test, assign) {
     generic::NSEC3 rdata_nsec3(nsec3_txt);
     generic::NSEC3 other_nsec3 = rdata_nsec3;
diff --git a/src/lib/dns/tests/rdata_nsec_unittest.cc b/src/lib/dns/tests/rdata_nsec_unittest.cc
index 88c6201..5e5ac89 100644
--- a/src/lib/dns/tests/rdata_nsec_unittest.cc
+++ b/src/lib/dns/tests/rdata_nsec_unittest.cc
@@ -66,6 +66,19 @@ TEST_F(Rdata_NSEC_Test, createFromWire_NSEC) {
     // Invalid bitmap cases are tested in Rdata_NSECBITMAP_Test.
 }
 
+TEST_F(Rdata_NSEC_Test, createFromLexer_NSEC) {
+    const generic::NSEC rdata_nsec(nsec_txt);
+    EXPECT_EQ(0, rdata_nsec.compare(
+        *test::createRdataUsingLexer(RRType::NSEC(), RRClass::IN(),
+                                     nsec_txt)));
+
+    // Check that bad input throws as usual
+    EXPECT_THROW({
+        *test::createRdataUsingLexer(RRType::NSEC(), RRClass::IN(),
+                                     "www.isc.org.");
+    }, InvalidRdataText);
+}
+
 TEST_F(Rdata_NSEC_Test, toWireRenderer_NSEC) {
     renderer.skip(2);
     const generic::NSEC rdata_nsec(nsec_txt);
diff --git a/src/lib/dns/tests/rdata_tsig_unittest.cc b/src/lib/dns/tests/rdata_tsig_unittest.cc
index c8ee8ac..f562d15 100644
--- a/src/lib/dns/tests/rdata_tsig_unittest.cc
+++ b/src/lib/dns/tests/rdata_tsig_unittest.cc
@@ -247,6 +247,18 @@ TEST_F(Rdata_TSIG_Test, createFromParams) {
                  isc::InvalidParameter);
 }
 
+TEST_F(Rdata_TSIG_Test, createFromLexer) {
+    EXPECT_EQ(0, rdata_tsig.compare(
+        *test::createRdataUsingLexer(RRType::TSIG(), RRClass::ANY(),
+                                     valid_text1)));
+
+    // Check that bad input throws as usual
+    EXPECT_THROW({
+        *test::createRdataUsingLexer(RRType::TSIG(), RRClass::ANY(),
+                                     "foo 0 0 0 0 BADKEY 0 0");
+    }, InvalidRdataText);
+}
+
 TEST_F(Rdata_TSIG_Test, assignment) {
     any::TSIG copy((string(valid_text2)));
     copy = rdata_tsig;