BIND 10 trac2204, updated. 86e4008ac1623aef96fd0c6140e5496841c3b9f0 [2204] removed an obsolete comment that only made sense for the previous code.

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Oct 10 16:22:32 UTC 2012


The branch, trac2204 has been updated
       via  86e4008ac1623aef96fd0c6140e5496841c3b9f0 (commit)
       via  f496bbe69fbff9228c48fc7bf9cc986ed7f420e4 (commit)
      from  1e93f1db983cc35b118853b88ab2919decafe2c5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
-----------------------------------------------------------------------

Summary of changes:
 src/bin/auth/datasrc_config.h |   14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/auth/datasrc_config.h b/src/bin/auth/datasrc_config.h
index 02e4e5c..5707c6c 100644
--- a/src/bin/auth/datasrc_config.h
+++ b/src/bin/auth/datasrc_config.h
@@ -35,6 +35,16 @@
 /// You don't need to pay attention to it, use the configureDataSource
 /// specialization instead.
 ///
+/// \note In future we may want to make the reconfiguration more efficient
+/// by only creating newly configured data and just moving the rest from
+/// the running configuration if they are used in the new configuration
+/// without any parameter change.  We could probably do it by passing
+/// the old lists in addition to the new config, but further details are
+/// still to be defined yet.  It will surely require changes in the
+/// data source library, too.  So, right now, we don't introduce the
+/// possibility in the function interface.  If and when we decide to introduce
+/// the optimization, we'll extend the interface.
+///
 /// \param config The configuration value to parse. It is in the form
 ///     as an update from the config manager.
 /// \return A map from RR classes to configured lists.
@@ -48,10 +58,8 @@ configureDataSourceGeneric(const isc::data::ConstElementPtr& config) {
 
     boost::shared_ptr<ListMap> new_lists(new ListMap);
 
-    // Get the configuration and current state.
-    const Map& map(config->mapValue());
-
     // Go through the configuration and create corresponding list.
+    const Map& map(config->mapValue());
     for (Map::const_iterator it(map.begin()); it != map.end(); ++it) {
         const isc::dns::RRClass rrclass(it->first);
         ListPtr list(new List(rrclass));



More information about the bind10-changes mailing list