BIND 10 trac2349, created. 95a47e7f0ac9e87d3d0c6c51c07e4761d0a50932 [2349] Same for RunningQuery

[BIND 10 source code commits]

The branch, trac2349 has been created
        at  95a47e7f0ac9e87d3d0c6c51c07e4761d0a50932 (commit)

- Log -----------------------------------------------------------------
commit 95a47e7f0ac9e87d3d0c6c51c07e4761d0a50932
Author: Jelte Jansen <jelte at isc.org>
Date:   Fri Oct 12 17:04:15 2012 +0200

    [2349] Same for RunningQuery
    
    See 26483ea27726d4c1097485196a0908c565478188

commit 26483ea27726d4c1097485196a0908c565478188
Author: Jelte Jansen <jelte at isc.org>
Date:   Fri Oct 12 14:19:19 2012 +0200

    [2349] clean up ForwardQuery objects in tests
    
    an attempt to clean up memory; ForwardQuery objects are supposed to delete themselves when they are no longer needed, but due to the direct calls in tests this often does not happen.
    
    To keep internals in recursive_query to a minimum, I did add something to the API; ForwardQuery is now a public class, a pointer of which is returned by RecursiveQuery::forward. Tests that mess around can then delete the query themselves, and the way these are handled does not have to be changed.
    
    Ideally, we should however not need unscoped allocated memory in the first place; we either need to use a centrally managed pool of objects to (re)use, or we need to change the entire design that needs these objects in the first place.
    
    However, these are both non-trivial, and probably better suited in the main resolver work that has been planned.

commit 030aef19982a37a8b81376adb15864097b208ff8
Author: Jelte Jansen <jelte at isc.org>
Date:   Thu Oct 11 17:22:23 2012 +0200

    [2349] Ignore EXPECT_DEATH when run in valgrind
    
    Valgrind complains (probably rightfully so) that memory is leaking in death-tests. This has been reported upstream, but is not addressed yet, and may not be in the near future, if at all (one response was don't use EXPECT_DEATH).
    
    So I added a checker function, *if* valgrind headers are available, that returns true if the tests are run under valgrind. Death tests are now ignored if so.
    
    Note that we should be very careful about using this; and only use it for things we are sure valgrind can't help, since it is possible to do things differently when using valgrind, which kind of defeats its purpose

-----------------------------------------------------------------------