BIND 10 trac2223, updated. 579b92381b604c84f70ae5fe6237ca5dc45a9302 [2223] some minor cleanups in final review
BIND 10 source code commits
bind10-changes at lists.isc.org
Tue Oct 16 12:43:55 UTC 2012
The branch, trac2223 has been updated
via 579b92381b604c84f70ae5fe6237ca5dc45a9302 (commit)
from 50500e62ac0b43e3579e98832b06bde19d01302c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 579b92381b604c84f70ae5fe6237ca5dc45a9302
Author: Jelte Jansen <jelte at isc.org>
Date: Tue Oct 16 14:43:42 2012 +0200
[2223] some minor cleanups in final review
-----------------------------------------------------------------------
Summary of changes:
src/lib/testutils/dnsmessage_test.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/testutils/dnsmessage_test.h b/src/lib/testutils/dnsmessage_test.h
index 2f3a136..7456b24 100644
--- a/src/lib/testutils/dnsmessage_test.h
+++ b/src/lib/testutils/dnsmessage_test.h
@@ -255,9 +255,9 @@ rrsetsCheck(EXPECTED_ITERATOR expected_begin, EXPECTED_ITERATOR expected_end,
// or they can have them attached to the RRset they cover.
// For ease of use of this method, we first flatten out both
// iterators, and pull out the signature sets, and add them as
- // separate RRsets (checkRRset() later does not check signatures
+ // separate RRsets (rrsetCheck() later does not check signatures
// attached to rrsets)
- std::vector<isc::dns::ConstRRsetPtr> actual_rrsets, expected_rrsets;
+ std::vector<isc::dns::ConstRRsetPtr> expected_rrsets, actual_rrsets;
std::string expected_text, actual_text;
pullSigs(expected_rrsets, expected_text, expected_begin, expected_end);
@@ -277,9 +277,9 @@ rrsetsCheck(EXPECTED_ITERATOR expected_begin, EXPECTED_ITERATOR expected_end,
std::vector<isc::dns::ConstRRsetPtr>::const_iterator it;
for (it = actual_rrsets.begin(); it != actual_rrsets.end(); ++it) {
// Make sure there's no duplicate RRset in actual (using a naive
- // search). Since the actual set is guaranteed to be unique, we can
- // detect it if the expected data has a duplicate by the match/size
- // checks at the end of the function.
+ // search). By guaranteeing the actual set is unique, and the
+ // size of both vectors is the same, we can conclude that
+ // the two sets are identical after this loop
// Note: we cannot use EXPECT_EQ for iterators
EXPECT_TRUE(checked_rrsets.end() ==
std::find_if(checked_rrsets.begin(), checked_rrsets.end(),
More information about the bind10-changes
mailing list