BIND 10 trac2207, updated. 83f878b651eb1be66dfcb1453cc074c2b5d3dc3f [2207] minor style cleanup: constify

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Oct 17 21:34:42 UTC 2012


The branch, trac2207 has been updated
       via  83f878b651eb1be66dfcb1453cc074c2b5d3dc3f (commit)
       via  100929f3fab349338ecbd8cbcdf090e1006f8ab0 (commit)
       via  7265ccb300bd2a2e1789d8ce99182e787d97181c (commit)
       via  399e4f0030d226010f2156e978fc2b7c179fe7b7 (commit)
       via  f0f7efe331713b84e4e95f872373d6d2906b5870 (commit)
      from  16041df526aeb519ff158aa4cd89e0b4f503aece (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 83f878b651eb1be66dfcb1453cc074c2b5d3dc3f
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Oct 17 13:07:40 2012 -0700

    [2207] minor style cleanup: constify

commit 100929f3fab349338ecbd8cbcdf090e1006f8ab0
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Oct 17 11:44:35 2012 -0700

    [2207] editorial: folded a long line

commit 7265ccb300bd2a2e1789d8ce99182e787d97181c
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Oct 17 11:38:54 2012 -0700

    [2207] editorial: folded long lines

commit 399e4f0030d226010f2156e978fc2b7c179fe7b7
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Oct 17 11:38:35 2012 -0700

    [2207] one more fix of s/reloader/writer/

commit f0f7efe331713b84e4e95f872373d6d2906b5870
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Wed Oct 17 10:49:19 2012 -0700

    [2207] editorial: some more s/reloader/write/ changes in doc.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/memory/zone_table_segment.h |    6 +++---
 src/lib/datasrc/memory/zone_writer.h        |    4 ++--
 src/lib/datasrc/memory/zone_writer_local.cc |    5 +++--
 src/lib/datasrc/memory/zone_writer_local.h  |    8 ++++----
 4 files changed, 12 insertions(+), 11 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/memory/zone_table_segment.h b/src/lib/datasrc/memory/zone_table_segment.h
index 996f446..74a3295 100644
--- a/src/lib/datasrc/memory/zone_table_segment.h
+++ b/src/lib/datasrc/memory/zone_table_segment.h
@@ -129,15 +129,15 @@ public:
     /// \param segment The segment to destroy.
     static void destroy(ZoneTableSegment* segment);
 
-    /// \brief Create a reloader corresponding to this segment
+    /// \brief Create a zone write corresponding to this segment
     ///
-    /// This creates a new reloader that can be used to reload zones
+    /// This creates a new write that can be used to update zones
     /// inside this zone table segment.
     ///
     /// \param loadAction Callback to provide the actual data.
     /// \param origin The origin of the zone to reload.
     /// \param rrclass The class of the zone to reload.
-    /// \return New instance of a zone reloader. The ownership is passed
+    /// \return New instance of a zone writer. The ownership is passed
     ///     onto the caller.
     virtual ZoneWriter* getZoneWriter(const LoadAction& load_action,
                                       const dns::Name& origin,
diff --git a/src/lib/datasrc/memory/zone_writer.h b/src/lib/datasrc/memory/zone_writer.h
index 6671429..8d19473 100644
--- a/src/lib/datasrc/memory/zone_writer.h
+++ b/src/lib/datasrc/memory/zone_writer.h
@@ -63,8 +63,8 @@ public:
     /// This may throw in rare cases, depending on the concrete implementation.
     /// If it throws, you still need to call cleanup().
     ///
-    /// \throw isc::InvalidOperation if called without previous load() or for the
-    ///     second time or cleanup() was called already.
+    /// \throw isc::InvalidOperation if called without previous load() or for
+    ///     the second time or cleanup() was called already.
     virtual void install() = 0;
 
     /// \brief Clean up resources.
diff --git a/src/lib/datasrc/memory/zone_writer_local.cc b/src/lib/datasrc/memory/zone_writer_local.cc
index 44ff03c..de3d91b 100644
--- a/src/lib/datasrc/memory/zone_writer_local.cc
+++ b/src/lib/datasrc/memory/zone_writer_local.cc
@@ -71,8 +71,9 @@ ZoneWriterLocal::install() {
     if (table == NULL) {
         isc_throw(isc::InvalidOperation, "No zone table present");
     }
-    ZoneTable::AddResult result(table->addZone(segment_->getMemorySegment(),
-                                               rrclass_, origin_, zone_data_));
+    const ZoneTable::AddResult result(table->addZone(
+                                          segment_->getMemorySegment(),
+                                          rrclass_, origin_, zone_data_));
 
     data_ready_ = false;
     zone_data_ = result.zone_data;
diff --git a/src/lib/datasrc/memory/zone_writer_local.h b/src/lib/datasrc/memory/zone_writer_local.h
index a106079..366ae1a 100644
--- a/src/lib/datasrc/memory/zone_writer_local.h
+++ b/src/lib/datasrc/memory/zone_writer_local.h
@@ -53,8 +53,8 @@ public:
     /// This calls the load_action (passed to constructor) and stores the
     /// data for future use.
     ///
-    /// \throw isc::InvalidOperation if it is called the second time in lifetime
-    ///     of the object.
+    /// \throw isc::InvalidOperation if it is called the second time in
+    ///     lifetime of the object.
     /// \throw Whatever the load_action throws, it is propagated up.
     virtual void load();
 
@@ -63,8 +63,8 @@ public:
     /// It modifies the zone table accessible through the segment (passed to
     /// constructor).
     ///
-    /// \throw isc::InvalidOperation if it is called the second time in lifetime
-    ///     of the object or if load() was not called previously or if
+    /// \throw isc::InvalidOperation if it is called the second time in
+    ///     lifetime of the object or if load() was not called previously or if
     ///     cleanup() was already called.
     virtual void install();
 



More information about the bind10-changes mailing list