BIND 10 trac2316, updated. 35300a55ab8bc113428142ea764a54173eb8f07f [2316] Passing option by reference as suggested in the review.

[BIND 10 source code commits]

The branch, trac2316 has been updated
       via  35300a55ab8bc113428142ea764a54173eb8f07f (commit)
      from  6c12b4328d0c49d039abc56ee22e09f8ca431647 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 35300a55ab8bc113428142ea764a54173eb8f07f
Author: Marcin Siodelski <marcin at isc.org>
Date:   Wed Oct 24 10:57:39 2012 +0200

    [2316] Passing option by reference as suggested in the review.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dhcp/subnet.cc |    4 ++--
 src/lib/dhcp/subnet.h  |    6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dhcp/subnet.cc b/src/lib/dhcp/subnet.cc
index 9853884..cb82a9f 100644
--- a/src/lib/dhcp/subnet.cc
+++ b/src/lib/dhcp/subnet.cc
@@ -97,7 +97,7 @@ Pool4Ptr Subnet4::getPool4(const isc::asiolink::IOAddress& hint /* = IOAddress("
 }
 
 void
-Subnet4::validateOption(OptionPtr option) const {
+Subnet4::validateOption(const OptionPtr& option) const {
     if (!option) {
         isc_throw(isc::BadValue, "option configured for subnet must not be NULL");
     } else if (option->getUniverse() != Option::V4) {
@@ -152,7 +152,7 @@ Pool6Ptr Subnet6::getPool6(const isc::asiolink::IOAddress& hint /* = IOAddress("
 }
 
 void
-Subnet6::validateOption(OptionPtr option) const {
+Subnet6::validateOption(const OptionPtr& option) const {
     if (!option) {
         isc_throw(isc::BadValue, "option configured for subnet must not be NULL");
     } else if (option->getUniverse() != Option::V6) {
diff --git a/src/lib/dhcp/subnet.h b/src/lib/dhcp/subnet.h
index df9c6af..aa680ce 100644
--- a/src/lib/dhcp/subnet.h
+++ b/src/lib/dhcp/subnet.h
@@ -255,7 +255,7 @@ protected:
     /// @brief Check if option is valid and can be added to a subnet.
     ///
     /// @param option option to be validated.
-    virtual void validateOption(OptionPtr option) const = 0;
+    virtual void validateOption(const OptionPtr& option) const = 0;
 
     /// @brief subnet-id
     ///
@@ -328,7 +328,7 @@ protected:
     /// @param option option to be validated.
     ///
     /// @throw isc::BadValue if provided option is invalid.
-    virtual void validateOption(OptionPtr option) const;
+    virtual void validateOption(const OptionPtr& option) const;
 
     /// @brief collection of pools in that list
     Pool4Collection pools_;
@@ -396,7 +396,7 @@ protected:
     /// @param option option to be validated.
     ///
     /// @throw isc::BadValue if provided option is invalid.
-    virtual void validateOption(OptionPtr option) const;
+    virtual void validateOption(const OptionPtr& option) const;
 
     /// @brief collection of pools in that list
     Pool6Collection pools_;