BIND 10 trac2318, updated. c4159fc5c746ee7df7aae8c590789e675050d75c [2318] Minor changes in comments, suggested in the code review.
BIND 10 source code commits
bind10-changes at lists.isc.org
Tue Oct 30 11:35:27 UTC 2012
The branch, trac2318 has been updated
via c4159fc5c746ee7df7aae8c590789e675050d75c (commit)
from 698ad7c5546e6f0e44be3d9ee1ae57e541a9f968 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c4159fc5c746ee7df7aae8c590789e675050d75c
Author: Marcin Siodelski <marcin at isc.org>
Date: Tue Oct 30 12:35:19 2012 +0100
[2318] Minor changes in comments, suggested in the code review.
-----------------------------------------------------------------------
Summary of changes:
src/bin/dhcp6/config_parser.cc | 9 +++++++++
src/bin/dhcp6/dhcp6.dox | 2 ++
2 files changed, 11 insertions(+)
-----------------------------------------------------------------------
diff --git a/src/bin/dhcp6/config_parser.cc b/src/bin/dhcp6/config_parser.cc
index bbbcfb1..2476497 100644
--- a/src/bin/dhcp6/config_parser.cc
+++ b/src/bin/dhcp6/config_parser.cc
@@ -142,6 +142,9 @@ protected:
///
/// For overview of usability of this generic purpose parser, see
/// \ref dhcpv6-config-inherit page.
+///
+/// @todo this class should be turned into the template class which
+/// will handle all uintX_types of data (see ticket #2415).
class Uint32Parser : public DhcpConfigParser {
public:
@@ -484,6 +487,12 @@ protected:
/// and data carried by the option. If parsing is successful than
/// instance of an option is created and added to the storage provided
/// by the calling class.
+///
+/// @todo This class parses and validates option name. However it is
+/// not used anywhere util support for option spaces is implemented
+/// (see tickets #2319, #2314). When option spaces are implemented
+/// there will be a way to reference the particular option using
+/// its type (code) or option name.
class OptionDataParser : public DhcpConfigParser {
public:
diff --git a/src/bin/dhcp6/dhcp6.dox b/src/bin/dhcp6/dhcp6.dox
index fe842de..6856aff 100644
--- a/src/bin/dhcp6/dhcp6.dox
+++ b/src/bin/dhcp6/dhcp6.dox
@@ -76,4 +76,6 @@
simple as possible. In fact, currently the code has to call Subnet6->getT1() and
do not implement any fancy inheritance logic.
+ @todo Add section about setting up options and their definitions with bindctl.
+
*/
More information about the bind10-changes
mailing list