BIND 10 trac2318, updated. c8d6f38ab7cea07e3bc75a5b4cec8207c2db61fd [2318] Test for very low negative value removed.
BIND 10 source code commits
bind10-changes at lists.isc.org
Tue Oct 30 19:45:09 UTC 2012
The branch, trac2318 has been updated
via c8d6f38ab7cea07e3bc75a5b4cec8207c2db61fd (commit)
from 17749f1ef367d560e5b878e814352e8b8082542e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c8d6f38ab7cea07e3bc75a5b4cec8207c2db61fd
Author: Marcin Siodelski <marcin at isc.org>
Date: Tue Oct 30 20:44:32 2012 +0100
[2318] Test for very low negative value removed.
Test was wrong because fromJSON function filters out low numbers anyway
and caused exception when preparing the data for the unit test.
-----------------------------------------------------------------------
Summary of changes:
src/bin/dhcp6/tests/config_parser_unittest.cc | 11 -----------
1 file changed, 11 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/dhcp6/tests/config_parser_unittest.cc b/src/bin/dhcp6/tests/config_parser_unittest.cc
index dafe314..489e3c1 100644
--- a/src/bin/dhcp6/tests/config_parser_unittest.cc
+++ b/src/bin/dhcp6/tests/config_parser_unittest.cc
@@ -571,17 +571,6 @@ TEST_F(Dhcp6ParserTest, optionNameSpaces) {
testInvalidOptionParam("option foo", "name");
}
-// Verify that very low negative option code is rejected in
-// the configuration.
-TEST_F(Dhcp6ParserTest, optionCodeNegativeOverflow) {
- // Using negative code. If range checking is not applied on the
- // value then it may be successfully cast to uint16_t resulting
- // in a value of 65531 (which will be accepted). The code should however
- // detect that it is actually very low negative value and parsing should
- // fail.
- testInvalidOptionParam("-4294901765", "code");
-}
-
// Verify that negative option code is rejected in the configuration.
TEST_F(Dhcp6ParserTest, optionCodeNegative) {
// Check negative option code -4. This should fail too.
More information about the bind10-changes
mailing list