BIND 10 trac2098, updated. 83a400743d99693d21fe04636c4958c3d82399f8 [2098] made TreeNodeRRset non-copyable explicitly and documented it.

BIND 10 source code commits bind10-changes at lists.isc.org
Mon Sep 3 12:54:56 UTC 2012


The branch, trac2098 has been updated
       via  83a400743d99693d21fe04636c4958c3d82399f8 (commit)
      from  49aabed090bd58b4aa295af86f106adbe2d5492b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 83a400743d99693d21fe04636c4958c3d82399f8
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Mon Sep 3 21:54:27 2012 +0900

    [2098] made TreeNodeRRset non-copyable explicitly and documented it.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/memory/treenode_rrset.h |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/memory/treenode_rrset.h b/src/lib/datasrc/memory/treenode_rrset.h
index 2ad3a3c..dd94245 100644
--- a/src/lib/datasrc/memory/treenode_rrset.h
+++ b/src/lib/datasrc/memory/treenode_rrset.h
@@ -28,6 +28,8 @@
 #include <datasrc/memory/zone_data.h>
 #include <datasrc/memory/rdataset.h>
 
+#include <boost/noncopyable.hpp>
+
 #include <string>
 
 namespace isc {
@@ -65,12 +67,17 @@ namespace memory {
 /// it should be safe, but we should eventually provide complete
 /// implementations of these methods.
 ///
+/// This class can internally maintain dynamically allocated resource.
+/// It would cause copying a class object complicated while objects of
+/// this class are not expected to be copyable in the usage, so it's
+/// explicitly defined non copyable.
+///
 /// \note This class is exposed in this separate header file so that other
 /// part of the in-memory data source implementation and test code
 /// can refer to its definition, and only for that purpose.  Otherwise this is
 /// essentially a private class of the in-memory data source implementation,
 /// and an application shouldn't directly refer to this class.
-class TreeNodeRRset : public dns::AbstractRRset {
+class TreeNodeRRset : boost::noncopyable, public dns::AbstractRRset {
 public:
     /// \brief Normal case constructor.
     ///



More information about the bind10-changes mailing list