BIND 10 trac2202, updated. c0128e80648ec83fb9f4e3cbf3bb7bba2ef0bbb5 Disable broken test

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Sep 4 10:39:10 UTC 2012


The branch, trac2202 has been updated
       via  c0128e80648ec83fb9f4e3cbf3bb7bba2ef0bbb5 (commit)
      from  b52c3d66c1462da3733725d2baf40a21b8f521d6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c0128e80648ec83fb9f4e3cbf3bb7bba2ef0bbb5
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Tue Sep 4 12:37:35 2012 +0200

    Disable broken test
    
    The test may be broken by design. In such case, it should be removed.
    But it is left there for now, maybe it's just broken implementation and
    someone (the reviewer?) may have an idea how to fix it.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/util/threads/tests/lock_unittest.cc |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/util/threads/tests/lock_unittest.cc b/src/lib/util/threads/tests/lock_unittest.cc
index c2755cf..19c1074 100644
--- a/src/lib/util/threads/tests/lock_unittest.cc
+++ b/src/lib/util/threads/tests/lock_unittest.cc
@@ -46,13 +46,17 @@ TEST(MutexTest, lockMultiple) {
 }
 
 // Destroying a locked mutex is a bad idea as well
-TEST(MutexTest, destroyLocked) {
+//
+// FIXME: The test is disabled, since it screws something up in the VM (other
+// tests fail then with rather cryptic messages, memory dumps and stuff).
+// Any idea how to make the test work and reasonably safe?
+TEST(MutexTest, DISABLED_destroyLocked) {
     // TODO: This probably won't work for non-debug mutexes. Disable on non-debug
     // compilation.
     Mutex* mutex = new Mutex;
-    Mutex::Locker* locker = new Mutex::Locker(*mutex);
+    new Mutex::Locker(*mutex);
     EXPECT_THROW(delete mutex, isc::InvalidOperation);
-    // Note: This maybe leaks the locker. But this is a test for development aid
+    // Note: This leaks the locker. But this is a test for development aid
     // exception. The exception won't happen in normal build anyway and seeing
     // it means there's a bug. And we can't delete the locker now, since it
     // would access uninitialized memory.



More information about the bind10-changes mailing list