BIND 10 trac2160, updated. edeea1792d69930f2e2aa1d5621e286e868c294b [2160] add comment about Message vars in sync_udp_server

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Sep 5 09:46:53 UTC 2012


The branch, trac2160 has been updated
       via  edeea1792d69930f2e2aa1d5621e286e868c294b (commit)
      from  9514bc87016b23bb56f615bc2dcb5f8d8f778a51 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit edeea1792d69930f2e2aa1d5621e286e868c294b
Author: Jelte Jansen <jelte at isc.org>
Date:   Wed Sep 5 11:46:21 2012 +0200

    [2160] add comment about Message vars in sync_udp_server

-----------------------------------------------------------------------

Summary of changes:
 src/lib/asiodns/sync_udp_server.cc |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

-----------------------------------------------------------------------
diff --git a/src/lib/asiodns/sync_udp_server.cc b/src/lib/asiodns/sync_udp_server.cc
index 037074a..0c577f2 100644
--- a/src/lib/asiodns/sync_udp_server.cc
+++ b/src/lib/asiodns/sync_udp_server.cc
@@ -114,7 +114,12 @@ SyncUDPServer::handleRead(const asio::error_code& ec, const size_t length) {
         return;
     }
 
-    // Make sure the buffers are fresh
+    // Make sure the buffers are fresh.  Note that we don't touch query_
+    // because it's supposed to be cleared in lookup_callback_.  We should
+    // eventually even remove this member variable (and remove it from
+    // the lookup_callback_ interface, but until then, any callback
+    // implementation should be careful that it's the responsibility of
+    // the callback implementation.  See also #2239).
     output_buffer_->clear();
     answer_->clear(isc::dns::Message::RENDER);
 



More information about the bind10-changes mailing list