BIND 10 trac2202, updated. a3e7cc6cf85981ed5a8a5e63589dfe1767b01e64 [2202] Unify class-struct
BIND 10 source code commits
bind10-changes at lists.isc.org
Wed Sep 5 11:04:05 UTC 2012
The branch, trac2202 has been updated
via a3e7cc6cf85981ed5a8a5e63589dfe1767b01e64 (commit)
via 382204ee795971bf6daeebb95f6134bab10ca18d (commit)
from e25a0b2202650ef749340a1993b427bf99d962e5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a3e7cc6cf85981ed5a8a5e63589dfe1767b01e64
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date: Wed Sep 5 13:03:33 2012 +0200
[2202] Unify class-struct
It should be the same according to the standard, but Clang seems not to
agree with that.
commit 382204ee795971bf6daeebb95f6134bab10ca18d
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date: Wed Sep 5 12:57:20 2012 +0200
[2202] Don't use PTHREAD_MUTEX_ROBUST
It seems it isn't portable and it's not very useful check.
-----------------------------------------------------------------------
Summary of changes:
src/lib/util/threads/lock.cc | 4 +---
src/lib/util/threads/lock.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/util/threads/lock.cc b/src/lib/util/threads/lock.cc
index 16e59bd..e3e9f7e 100644
--- a/src/lib/util/threads/lock.cc
+++ b/src/lib/util/threads/lock.cc
@@ -78,9 +78,7 @@ Mutex::Mutex(bool recursive) :
if (recursive) {
type = PTHREAD_MUTEX_RECURSIVE;
}
- // Stop on first error you find and store the result.
- result = pthread_mutexattr_settype(&attributes, type) ||
- pthread_mutexattr_setrobust(&attributes, PTHREAD_MUTEX_ROBUST);
+ result = pthread_mutexattr_settype(&attributes, type);
if (result != 0) {
isc_throw(isc::InvalidOperation, strerror(result));
}
diff --git a/src/lib/util/threads/lock.h b/src/lib/util/threads/lock.h
index 10a7878..2c2dab8 100644
--- a/src/lib/util/threads/lock.h
+++ b/src/lib/util/threads/lock.h
@@ -125,7 +125,7 @@ public:
bool locked() const;
private:
friend class Locker;
- struct Impl;
+ class Impl;
Impl* impl_;
void lock();
void unlock();
More information about the bind10-changes
mailing list