BIND 10 trac2108_3, updated. bff38dc7a6eae26d1b6178088197bb1467746377 [2108] Add another TODO comment

BIND 10 source code commits bind10-changes at lists.isc.org
Thu Sep 6 04:57:36 UTC 2012


The branch, trac2108_3 has been updated
       via  bff38dc7a6eae26d1b6178088197bb1467746377 (commit)
       via  fb5704f3df5b34c1a8630650257ccd2317d784dc (commit)
       via  7a3b73ce16268558c72244b91f08d4768a55133c (commit)
      from  105b19f75e8d0158a1370faae8ac4dd99ed0752c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bff38dc7a6eae26d1b6178088197bb1467746377
Author: Mukund Sivaraman <muks at isc.org>
Date:   Thu Sep 6 10:27:10 2012 +0530

    [2108] Add another TODO comment

commit fb5704f3df5b34c1a8630650257ccd2317d784dc
Author: Mukund Sivaraman <muks at isc.org>
Date:   Thu Sep 6 10:26:56 2012 +0530

    [2108] Wrap lines

commit 7a3b73ce16268558c72244b91f08d4768a55133c
Author: Mukund Sivaraman <muks at isc.org>
Date:   Thu Sep 6 10:26:29 2012 +0530

    [2108] Remove some unused variables

-----------------------------------------------------------------------

Summary of changes:
 .../datasrc/memory/tests/memory_client_unittest.cc |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/memory/tests/memory_client_unittest.cc b/src/lib/datasrc/memory/tests/memory_client_unittest.cc
index 2625ef8..2bc1e96 100644
--- a/src/lib/datasrc/memory/tests/memory_client_unittest.cc
+++ b/src/lib/datasrc/memory/tests/memory_client_unittest.cc
@@ -65,10 +65,7 @@ private:
 class MemoryClientTest : public ::testing::Test {
 protected:
     MemoryClientTest() : zclass_(RRClass::IN()),
-                      zname1(Name("example.com")),
-                      zname2(Name("example.net")),
-                      zname3(Name("example")),
-                      client_(new InMemoryClient(zclass_))
+                         client_(new InMemoryClient(zclass_))
     {}
     ~MemoryClientTest() {
         if (client_ != NULL) {
@@ -81,7 +78,6 @@ protected:
         EXPECT_TRUE(mem_sgmt_.allMemoryDeallocated()); // catch any leak here.
     }
     const RRClass zclass_;
-    const Name zname1, zname2, zname3;
     TestMemorySegment mem_sgmt_;
     InMemoryClient* client_;
     memory::ZoneTable* zone_table;
@@ -153,7 +149,8 @@ TEST_F(MemoryClientTest, loadRRSIGTypeUnmatched) {
 }
 
 TEST_F(MemoryClientTest, loadRRSIGs) {
-    client_->load(Name("example.org"), TEST_DATA_DIR "/example.org-rrsigs.zone");
+    client_->load(Name("example.org"),
+		  TEST_DATA_DIR "/example.org-rrsigs.zone");
     EXPECT_EQ(1, client_->getZoneCount());
 }
 
@@ -251,4 +248,5 @@ TEST_F(MemoryClientTest, getJournalReaderNotImplemented) {
 // TODO:
 // Add test for add() with separate_rrs=true
 // Add test for ZoneIterator variant of load()
+// Add test for leaks during allocation failures using TestMemorySegment
 }



More information about the bind10-changes mailing list