BIND 10 master, updated. 31c4fcd5cd9f77e112090250d2571f975dba7ef4 [master] Allow for one more second in NXDOMAIN TTL checks
BIND 10 source code commits
bind10-changes at lists.isc.org
Fri Sep 7 12:14:02 UTC 2012
The branch, master has been updated
via 31c4fcd5cd9f77e112090250d2571f975dba7ef4 (commit)
from f6e2c9efff82b96e59b27a6eae84900e25447f39 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 31c4fcd5cd9f77e112090250d2571f975dba7ef4
Author: Jeremy C. Reed <jreed at ISC.org>
Date: Fri Sep 7 07:12:23 2012 -0500
[master] Allow for one more second in NXDOMAIN TTL checks
We have had 34 random off-by-one failures on real and virtual machines.
Previously it allowed a two second range (it slept for 2 seconds).
Now allow a three second range.
Discussed on jabber.
-----------------------------------------------------------------------
Summary of changes:
src/lib/cache/tests/negative_cache_unittest.cc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/cache/tests/negative_cache_unittest.cc b/src/lib/cache/tests/negative_cache_unittest.cc
index 4935e4a..7853763 100644
--- a/src/lib/cache/tests/negative_cache_unittest.cc
+++ b/src/lib/cache/tests/negative_cache_unittest.cc
@@ -98,8 +98,9 @@ TEST_F(NegativeCacheTest, testNXDOMAIN){
rrset_ptr = *iter;
// The TTL should equal to the TTL of negative response SOA record
+ // Allow for three second range.
const RRTTL& nxdomain_ttl2 = rrset_ptr->getTTL();
- EXPECT_GE(nxdomain_ttl2.getValue(), 86397);
+ EXPECT_GE(nxdomain_ttl2.getValue(), 86396);
EXPECT_LE(nxdomain_ttl2.getValue(), 86398);
// No RRset in ANSWER section
EXPECT_TRUE(msg_nxdomain2.getRRCount(Message::SECTION_ANSWER) == 0);
@@ -120,7 +121,8 @@ TEST_F(NegativeCacheTest, testNXDOMAIN){
rrset_ptr = *iter;
const RRTTL& soa_ttl2 = rrset_ptr->getTTL();
// The TTL should equal to the TTL of SOA record in answer section
- EXPECT_GE(soa_ttl2.getValue(), 172797);
+ // Allow for three second range.
+ EXPECT_GE(soa_ttl2.getValue(), 172796);
EXPECT_LE(soa_ttl2.getValue(), 172798);
}
More information about the bind10-changes
mailing list