BIND 10 master, updated. c3689c6a256a1a77993ec743be8bd76506b72bd2 [master] cleanup version-check sqt statements

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Sep 7 13:04:37 UTC 2012


The branch, master has been updated
       via  c3689c6a256a1a77993ec743be8bd76506b72bd2 (commit)
      from  e1631485dc9fe6cbe061b4a4a3f5a5b6c6cd8080 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c3689c6a256a1a77993ec743be8bd76506b72bd2
Author: Jelte Jansen <jelte at isc.org>
Date:   Fri Sep 7 15:03:39 2012 +0200

    [master] cleanup version-check sqt statements
    
    This should fix the valgrind error report, verified on jabber

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/sqlite3_accessor.cc |    3 +++
 1 file changed, 3 insertions(+)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/sqlite3_accessor.cc b/src/lib/datasrc/sqlite3_accessor.cc
index 457d578..24d7b3f 100644
--- a/src/lib/datasrc/sqlite3_accessor.cc
+++ b/src/lib/datasrc/sqlite3_accessor.cc
@@ -394,16 +394,19 @@ int checkSchemaVersionElement(sqlite3* db, const char* const query) {
         if (rc == SQLITE_ERROR) {
             // this is the error that is returned when the table does not
             // exist
+            sqlite3_finalize(prepared);
             return (-1);
         } else if (rc == SQLITE_OK) {
             break;
         } else if (rc != SQLITE_BUSY || i == 50) {
+            sqlite3_finalize(prepared);
             isc_throw(SQLite3Error, "Unable to prepare version query: "
                         << rc << " " << sqlite3_errmsg(db));
         }
         doSleep();
     }
     if (sqlite3_step(prepared) != SQLITE_ROW) {
+        sqlite3_finalize(prepared);
         isc_throw(SQLite3Error,
                     "Unable to query version: " << sqlite3_errmsg(db));
     }



More information about the bind10-changes mailing list