BIND 10 trac2108_3, updated. 7f4c06a3fcbbff054ff5227b7b3b60f865b8ed46 [2108] Fix doc comment for InMemoryClient::getFileName()

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Sep 14 05:26:08 UTC 2012


The branch, trac2108_3 has been updated
       via  7f4c06a3fcbbff054ff5227b7b3b60f865b8ed46 (commit)
       via  2de58c844cbf6ab10fa9bbe2e45b09badcd3101b (commit)
       via  514cf93463cd28391d257672726077717580a9c3 (commit)
      from  56afaa4d876b6af0814e396c95d9375305878737 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7f4c06a3fcbbff054ff5227b7b3b60f865b8ed46
Author: Mukund Sivaraman <muks at isc.org>
Date:   Fri Sep 14 10:55:38 2012 +0530

    [2108] Fix doc comment for InMemoryClient::getFileName()

commit 2de58c844cbf6ab10fa9bbe2e45b09badcd3101b
Author: Mukund Sivaraman <muks at isc.org>
Date:   Fri Sep 14 10:51:27 2012 +0530

    [2108] Update obsolete comment

commit 514cf93463cd28391d257672726077717580a9c3
Author: Mukund Sivaraman <muks at isc.org>
Date:   Fri Sep 14 10:49:55 2012 +0530

    [2108] Sort the memory_messages.mes file

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/memory/memory_client.h     |   11 ++--
 src/lib/datasrc/memory/memory_messages.mes |   84 ++++++++++++++--------------
 2 files changed, 48 insertions(+), 47 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/memory/memory_client.h b/src/lib/datasrc/memory/memory_client.h
index a281259..dd0058e 100644
--- a/src/lib/datasrc/memory/memory_client.h
+++ b/src/lib/datasrc/memory/memory_client.h
@@ -45,8 +45,8 @@ namespace memory {
 /// allowing much faster lookups.  The in memory data is a copy of some
 /// real physical source - in the current implementation a list of zones
 /// are populated as a result of \c load() calls; zone data is given in
-/// a standard master file (but there's a plan to use database backends
-/// as a source of the in memory data).
+/// a standard master file, or as an iterator of some other datasource
+/// including database backed ones.
 ///
 /// The InMemoryClient enforces through its interface that all data
 /// loaded to the data source is of the same RR class.  For example, the
@@ -132,14 +132,15 @@ public:
     ///
     /// This method returns the name of the zone's master file to be loaded.
     /// The returned string will be an empty unless the data source client has
-    /// successfully loaded the zone before.
+    /// successfully loaded the \c zone_name zone from a file before.
     ///
     /// This method should normally not throw an exception.  But the creation
     /// of the return string may involve a resource allocation, and if it
     /// fails, the corresponding standard exception will be thrown.
     ///
-    /// \return The name of the zone file loaded in the client, or an empty
-    /// string if the client hasn't loaded any file.
+    /// \return The name of the zone file corresponding to the zone, or
+    /// an empty string if the client hasn't loaded the \c zone_name
+    /// zone from a file before.
     const std::string getFileName(const isc::dns::Name& zone_name) const;
 
     /// \brief Inserts an rrset into the zone.
diff --git a/src/lib/datasrc/memory/memory_messages.mes b/src/lib/datasrc/memory/memory_messages.mes
index a66297c..1b67093 100644
--- a/src/lib/datasrc/memory/memory_messages.mes
+++ b/src/lib/datasrc/memory/memory_messages.mes
@@ -16,61 +16,50 @@ $NAMESPACE isc::datasrc::memory
 
 # \brief Messages for the data source memory library
 
+% DATASRC_MEMORY_BAD_NSEC3_NAME NSEC3 record has a bad owner name '%1'
+The software refuses to load NSEC3 records into a wildcard domain or
+the owner name has two or more labels below the zone origin.
+It isn't explicitly forbidden, but no sane zone wouldn have such names
+for NSEC3.  BIND 9 also refuses NSEC3 at wildcard, so this behavior is
+compatible with BIND 9.
+
+% DATASRC_MEMORY_MEM_ADD_RRSET adding RRset '%1/%2' into zone '%3'
+Debug information. An RRset is being added to the in-memory data source.
+
 % DATASRC_MEMORY_MEM_ADD_WILDCARD adding wildcards for '%1'
 This is a debug message issued during the processing of a wildcard
 name. The internal domain name tree is scanned and some nodes are
 specially marked to allow the wildcard lookup to succeed.
 
-% DATASRC_MEMORY_MEM_CNAME_TO_NONEMPTY can't add CNAME to domain with other data in '%1'
-Someone or something tried to add a CNAME into a domain that already contains
-some other data. But the protocol forbids coexistence of CNAME with anything
-(RFC 1034, section 3.6.2). This indicates a problem with provided data.
+% DATASRC_MEMORY_MEM_ADD_ZONE adding zone '%1/%2'
+Debug information. A zone is being added into the in-memory data source.
 
 % DATASRC_MEMORY_MEM_CNAME_COEXIST can't add data to CNAME in domain '%1'
 This is the same problem as in MEM_CNAME_TO_NONEMPTY, but it happened the
 other way around -- adding some other data to CNAME.
 
+% DATASRC_MEMORY_MEM_CNAME_TO_NONEMPTY can't add CNAME to domain with other data in '%1'
+Someone or something tried to add a CNAME into a domain that already contains
+some other data. But the protocol forbids coexistence of CNAME with anything
+(RFC 1034, section 3.6.2). This indicates a problem with provided data.
+
 % DATASRC_MEMORY_MEM_DNAME_NS DNAME and NS can't coexist in non-apex domain '%1'
 A request was made for DNAME and NS records to be put into the same
 domain which is not the apex (the top of the zone). This is forbidden
 by RFC 2672 (section 3) and indicates a problem with provided data.
 
-% DATASRC_MEMORY_MEM_SINGLETON trying to add multiple RRs for domain '%1' and type '%2'
-Some resource types are singletons -- only one is allowed in a domain
-(for example CNAME or SOA). This indicates a problem with provided data.
-
-% DATASRC_MEMORY_MEM_OUT_OF_ZONE domain '%1' doesn't belong to zone '%2'
-It was attempted to add the domain into a zone that shouldn't have it
-(eg. the domain is not subdomain of the zone origin). This indicates a
-problem with provided data.
-
-% DATASRC_MEMORY_MEM_WILDCARD_NS NS record in wildcard domain '%1'
-The software refuses to load NS records into a wildcard domain.  It isn't
-explicitly forbidden, but the protocol is ambiguous about how this should
-behave and BIND 9 refuses that as well. Please describe your intention using
-different tools.
-
-% DATASRC_MEMORY_MEM_WILDCARD_DNAME DNAME record in wildcard domain '%1'
-The software refuses to load DNAME records into a wildcard domain.  It isn't
-explicitly forbidden, but the protocol is ambiguous about how this should
-behave and BIND 9 refuses that as well. Please describe your intention using
-different tools.
-
-% DATASRC_MEMORY_BAD_NSEC3_NAME NSEC3 record has a bad owner name '%1'
-The software refuses to load NSEC3 records into a wildcard domain or
-the owner name has two or more labels below the zone origin.
-It isn't explicitly forbidden, but no sane zone wouldn have such names
-for NSEC3.  BIND 9 also refuses NSEC3 at wildcard, so this behavior is
-compatible with BIND 9.
-
-% DATASRC_MEMORY_MEM_ADD_RRSET adding RRset '%1/%2' into zone '%3'
-Debug information. An RRset is being added to the in-memory data source.
-
 % DATASRC_MEMORY_MEM_DUP_RRSET duplicate RRset '%1/%2'
 An RRset is being inserted into in-memory data source for a second time.  The
 original version must be removed first. Note that loading master files where an
 RRset is split into multiple locations is not supported yet.
 
+% DATASRC_MEMORY_MEM_FIND_ZONE looking for zone '%1'
+Debug information. A zone object for this zone is being searched for in the
+in-memory data source.
+
+% DATASRC_MEMORY_MEM_LOAD loading zone '%1' from file '%2'
+Debug information. The content of master file is being loaded into the memory.
+
 % DATASRC_MEMORY_MEM_NO_NSEC3PARAM NSEC3PARAM is missing for NSEC3-signed zone %1/%2
 The in-memory data source has loaded a zone signed with NSEC3 RRs,
 but it doesn't have a NSEC3PARAM RR at the zone origin.  It's likely that
@@ -79,12 +68,23 @@ handling lookups with NSEC3 in this data source, so it accepts the given
 content of the zone.  Nevertheless the administrator should look into
 the integrity of the zone data.
 
-% DATASRC_MEMORY_MEM_ADD_ZONE adding zone '%1/%2'
-Debug information. A zone is being added into the in-memory data source.
+% DATASRC_MEMORY_MEM_OUT_OF_ZONE domain '%1' doesn't belong to zone '%2'
+It was attempted to add the domain into a zone that shouldn't have it
+(eg. the domain is not subdomain of the zone origin). This indicates a
+problem with provided data.
 
-% DATASRC_MEMORY_MEM_FIND_ZONE looking for zone '%1'
-Debug information. A zone object for this zone is being searched for in the
-in-memory data source.
+% DATASRC_MEMORY_MEM_SINGLETON trying to add multiple RRs for domain '%1' and type '%2'
+Some resource types are singletons -- only one is allowed in a domain
+(for example CNAME or SOA). This indicates a problem with provided data.
 
-% DATASRC_MEMORY_MEM_LOAD loading zone '%1' from file '%2'
-Debug information. The content of master file is being loaded into the memory.
+% DATASRC_MEMORY_MEM_WILDCARD_DNAME DNAME record in wildcard domain '%1'
+The software refuses to load DNAME records into a wildcard domain.  It isn't
+explicitly forbidden, but the protocol is ambiguous about how this should
+behave and BIND 9 refuses that as well. Please describe your intention using
+different tools.
+
+% DATASRC_MEMORY_MEM_WILDCARD_NS NS record in wildcard domain '%1'
+The software refuses to load NS records into a wildcard domain.  It isn't
+explicitly forbidden, but the protocol is ambiguous about how this should
+behave and BIND 9 refuses that as well. Please describe your intention using
+different tools.



More information about the bind10-changes mailing list