BIND 10 trac1545, updated. 38c6a4866e5be6f6a7ed3497f0fef252583b5be4 [1545] Added reference to python documentation for os.putenv() function.
BIND 10 source code commits
bind10-changes at lists.isc.org
Fri Sep 14 17:14:46 UTC 2012
The branch, trac1545 has been updated
via 38c6a4866e5be6f6a7ed3497f0fef252583b5be4 (commit)
from d6f3e1aa02ffc1de9d55a586174022eb60f43887 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 38c6a4866e5be6f6a7ed3497f0fef252583b5be4
Author: Marcin Siodelski <marcin at isc.org>
Date: Fri Sep 14 19:14:34 2012 +0200
[1545] Added reference to python documentation for os.putenv() function.
The os.putenv() functionsseems to be not supported on all platforms and
this is indicated in the python documentation.
-----------------------------------------------------------------------
Summary of changes:
src/bin/dhcp4/tests/dhcp4_test.py | 8 ++++++--
src/bin/dhcp6/tests/dhcp6_test.py | 8 ++++++--
2 files changed, 12 insertions(+), 4 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/dhcp4/tests/dhcp4_test.py b/src/bin/dhcp4/tests/dhcp4_test.py
index efe16fb..444dfcf 100644
--- a/src/bin/dhcp4/tests/dhcp4_test.py
+++ b/src/bin/dhcp4/tests/dhcp4_test.py
@@ -32,8 +32,12 @@ class TestDhcpv4Daemon(unittest.TestCase):
#
# However, we do want to set the logging lock directory to somewhere
# to which we can write - use the current working directory. We then
- # set the appropriate environment variable. os.putenv() doesn't work
- # on Ubuntu, so we access os.environ directly.
+ # set the appropriate environment variable. os.putenv() may be not
+ # supported on some platforms as suggested in
+ # http://docs.python.org/release/3.2/library/os.html?highlight=putenv#os.environ:
+ # "If the platform supports the putenv() function...". It was checked
+ # that it does not work on Ubuntu. To overcome this problem we access
+ # os.environ directly.
lockdir_envvar = "B10_LOCKFILE_DIR_FROM_BUILD"
if lockdir_envvar not in os.environ:
os.environ[lockdir_envvar] = os.getcwd()
diff --git a/src/bin/dhcp6/tests/dhcp6_test.py b/src/bin/dhcp6/tests/dhcp6_test.py
index 78202bd..f3099b9 100644
--- a/src/bin/dhcp6/tests/dhcp6_test.py
+++ b/src/bin/dhcp6/tests/dhcp6_test.py
@@ -32,8 +32,12 @@ class TestDhcpv6Daemon(unittest.TestCase):
#
# However, we do want to set the logging lock directory to somewhere
# to which we can write - use the current working directory. We then
- # set the appropriate environment variable. os.putenv() doesn't work
- # on Ubuntu, so we access os.environ directly.
+ # set the appropriate environment variable. os.putenv() may be not
+ # supported on some platforms as suggested in
+ # http://docs.python.org/release/3.2/library/os.html?highlight=putenv#os.environ:
+ # "If the platform supports the putenv() function...". It was checked
+ # that it does not work on Ubuntu. To overcome this problem we access
+ # os.environ directly.
lockdir_envvar = "B10_LOCKFILE_DIR_FROM_BUILD"
if lockdir_envvar not in os.environ:
os.environ[lockdir_envvar] = os.getcwd()
More information about the bind10-changes
mailing list