BIND 10 trac2267, created. 9eeacfa616c813189a516f343c320d65ed9bfc7d [2267] (unrelated) comment (and some style) cleanups.

[BIND 10 source code commits]

The branch, trac2267 has been created
        at  9eeacfa616c813189a516f343c320d65ed9bfc7d (commit)

- Log -----------------------------------------------------------------
commit 9eeacfa616c813189a516f343c320d65ed9bfc7d
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 18:50:57 2012 -0700

    [2267] (unrelated) comment (and some style) cleanups.
    
    some comments were obsolete in the newer implementation.  they were updated
    or simply removed.

commit 9d974a35bb76a63c7d8749d5728612ab0ef83c98
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 18:37:06 2012 -0700

    [2267] cleanup: make retval of impl::add() void.
    
    in the new implementation it always returns SUCCESS anyway, so it doesn't make
    sense to return it and check the value.

commit 71bfb14495829b1e03c79a03e6a1cd44c4d3a1b9
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 18:33:04 2012 -0700

    [2267] cleanup: pass zone name and data at the loader construction.

commit f0d4fcf168a840786ff9172ae23402920c85f3de
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 18:28:36 2012 -0700

    [2267] catch and reject the bogus case of passing empty RRSIG

commit dfc2f2b4dd181378d493aad1c53c8fcc53ba8152
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 18:15:49 2012 -0700

    [2267] some comments

commit 5a493720575e76a80ed6bba5cfcd2fac01364ce2
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 18:11:08 2012 -0700

    [2267] catch and reject RRSIGs that don't have a covered RRset.
    
    the loadRRSIGFollowsNothing test now passes and is re-enabled.
    the 'name unmatched' and 'type unmatched' tests are essentially the same
    so are removed (so are their test zone files).

commit 869d1d20492f5221714d2fbf7c39bef800a28e60
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 18:01:20 2012 -0700

    [2267] cover the case separated RRSIGs of the same type are given.

commit a65bda660f985ff422b1528b1f7654ac254c6a79
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 17:28:57 2012 -0700

    [2267] enabled the commented RRSIG test data, with which it now passes.

commit 5ffdbdff90641201be36ab0ee65773df2ef6e0dd
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 17:21:04 2012 -0700

    [2267] cleanup: removed last_rrset_. we don't need this beast any more.

commit b90b048ba805efc450026c5192bb09aa7668d52f
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 17:18:29 2012 -0700

    [2267] cleanup: removed now-unused methods
    
    and renamed addRdataSet2 to addRdataSet now that we don't have to distingush
    these two.

commit eb64f1c38d521886fef599582b4c80e892e31341
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 17:15:40 2012 -0700

    [2267] temporarily disabled some tests, which should expect a different result.

commit 6f4b4413fad5433ff41cd2b51f4784cbedfa859b
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 17:10:11 2012 -0700

    [2267] add RRsets to zone via the new loader class, ensuring the pairing.
    
    this fixes the main issue of this ticket, but made some other tests fail
    (which will be addressed in later commits)

commit 55f047a3e275e54e45a027631d1bd7e900b661f7
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 14:18:17 2012 -0700

    [2267] refactoring: introduce a helper Loader class and move addFromLoad there.

commit 7e5dbd9146f8c9a27937b733a63116d25865cf45
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 13:53:57 2012 -0700

    [2267] have add() take both RRset and RRSIG at the same time.
    
    as a helper another version of addRdataSet() is introduced too.
    these don't need the last_rrset_ magic.
    InMemoryClient::add now uses this version.

commit 4a78f86fffe147322f65b581a89d834b50999f39
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 12:20:18 2012 -0700

    [2267] added a test that checks if load() with separate_rr iterator fails.
    
    to catch any later regression.

commit ac96bd4de08738f779e79cc9cd15c88a63fb32bf
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 11:57:16 2012 -0700

    [2267] unrelated cleanup: use MemorySegmentTest for instrumental mem segment
    
    instead of a local copy of it inside memory_client_unittest.

commit 91a32d4c23fdb0780a78cae0fe34cec2ef64cffb
Author: JINMEI Tatuya <jinmei at isc.org>
Date:   Tue Sep 18 11:17:37 2012 -0700

    [2267] added RRSIGs to test iterator for memory client tests
    
    with a commented-out one that would reveal a bug of the implementation.
    also did some trivial style fixes.

-----------------------------------------------------------------------