BIND 10 trac1960, updated. 4f202471b02965f0bd3c402d1bffa503c5ee6527 [1960] Added comments why testing CommandOptions::isUseFirst().

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Sep 21 18:04:30 UTC 2012


The branch, trac1960 has been updated
       via  4f202471b02965f0bd3c402d1bffa503c5ee6527 (commit)
      from  7f5343e069bf811dc88bea5fad759bbe7fe4f78c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4f202471b02965f0bd3c402d1bffa503c5ee6527
Author: Marcin Siodelski <marcin at isc.org>
Date:   Fri Sep 21 20:04:17 2012 +0200

    [1960] Added comments why testing CommandOptions::isUseFirst().

-----------------------------------------------------------------------

Summary of changes:
 tests/tools/perfdhcp/test_control.cc |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-----------------------------------------------------------------------
diff --git a/tests/tools/perfdhcp/test_control.cc b/tests/tools/perfdhcp/test_control.cc
index abc62b2..636fe62 100644
--- a/tests/tools/perfdhcp/test_control.cc
+++ b/tests/tools/perfdhcp/test_control.cc
@@ -1347,6 +1347,8 @@ TestControl::sendRequest4(const TestControlSocket& socket,
     OptionPtr opt_msg_type = Option::factory(Option::V4, DHO_DHCP_MESSAGE_TYPE,
                                              buf_msg_type);
     pkt4->addOption(opt_msg_type);
+    // Use first flags indicates that we want to use the server
+    // id captured in first packet.
     if (CommandOptions::instance().isUseFirst() &&
         (first_packet_serverid_.size() > 0)) {
         pkt4->addOption(Option::factory(Option::V4, DHO_DHCP_SERVER_IDENTIFIER,
@@ -1442,6 +1444,8 @@ TestControl::sendRequest4(const TestControlSocket& socket,
 
     // Get the actual server id offset.
     size_t sid_offset = getServerIdOffset();
+    // Use first flags indicates that we want to use the server
+    // id captured in first packet.
     if (CommandOptions::instance().isUseFirst() &&
         (first_packet_serverid_.size() > 0)) {
         boost::shared_ptr<LocalizedOption>
@@ -1520,7 +1524,7 @@ TestControl::sendRequest6(const TestControlSocket& socket,
     pkt6->addOption(opt_clientid);
 
     // Use first flags indicates that we want to use the server
-    // id captured in fisrt packet.
+    // id captured in first packet.
     if (CommandOptions::instance().isUseFirst() &&
         (first_packet_serverid_.size() > 0)) {
         pkt6->addOption(Option::factory(Option::V6, D6O_SERVERID,
@@ -1578,6 +1582,8 @@ TestControl::sendRequest6(const TestControlSocket& socket,
 
     // Get the actual server id offset.
     size_t sid_offset = getServerIdOffset();
+    // Use first flags indicates that we want to use the server
+    // id captured in first packet.
     if (CommandOptions::instance().isUseFirst() &&
         (first_packet_serverid_.size() > 0)) {
         boost::shared_ptr<LocalizedOption>



More information about the bind10-changes mailing list