BIND 10 trac2831, updated. 639532ca50d317fdee78374be0e05c0c43ee2a0d [2831] Some minor comment updates
BIND 10 source code commits
bind10-changes at lists.isc.org
Thu Apr 4 14:24:33 UTC 2013
The branch, trac2831 has been updated
via 639532ca50d317fdee78374be0e05c0c43ee2a0d (commit)
via e1126a32146e14b8816b7a3fb733f3836ca61379 (commit)
via 252e7844e40e29ba6a7a30498bf525b75deb8219 (commit)
from 67d05b954c47821d6a29ba093632604c49fb794c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 639532ca50d317fdee78374be0e05c0c43ee2a0d
Author: Mukund Sivaraman <muks at isc.org>
Date: Thu Apr 4 19:54:19 2013 +0530
[2831] Some minor comment updates
commit e1126a32146e14b8816b7a3fb733f3836ca61379
Author: Mukund Sivaraman <muks at isc.org>
Date: Thu Apr 4 19:54:01 2013 +0530
[2831] Clarify comment about overflow
commit 252e7844e40e29ba6a7a30498bf525b75deb8219
Author: Mukund Sivaraman <muks at isc.org>
Date: Thu Apr 4 19:53:30 2013 +0530
[2831] Rename some variables to full names (that are not very long)
-----------------------------------------------------------------------
Summary of changes:
src/lib/util/memory_segment_mapped.cc | 8 ++++----
src/lib/util/memory_segment_mapped.h | 6 +++---
2 files changed, 7 insertions(+), 7 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/util/memory_segment_mapped.cc b/src/lib/util/memory_segment_mapped.cc
index b1cd25b..3a90ccd 100644
--- a/src/lib/util/memory_segment_mapped.cc
+++ b/src/lib/util/memory_segment_mapped.cc
@@ -248,13 +248,13 @@ MemorySegmentMapped::getSize() const {
size_t
MemorySegmentMapped::getCheckSum() const {
- const size_t page_sz = boost::interprocess::mapped_region::get_page_size();
- const uint8_t* const cp_beg = static_cast<const uint8_t*>(
+ const size_t pagesize = boost::interprocess::mapped_region::get_page_size();
+ const uint8_t* const cp_begin = static_cast<const uint8_t*>(
impl_->base_sgmt_->get_address());
- const uint8_t* const cp_end = cp_beg + impl_->base_sgmt_->get_size();
+ const uint8_t* const cp_end = cp_begin + impl_->base_sgmt_->get_size();
size_t sum = 0;
- for (const uint8_t* cp = cp_beg; cp < cp_end; cp += page_sz) {
+ for (const uint8_t* cp = cp_begin; cp < cp_end; cp += pagesize) {
sum += *cp;
}
diff --git a/src/lib/util/memory_segment_mapped.h b/src/lib/util/memory_segment_mapped.h
index cb91da0..b5baea1 100644
--- a/src/lib/util/memory_segment_mapped.h
+++ b/src/lib/util/memory_segment_mapped.h
@@ -173,7 +173,7 @@ public:
/// \brief Return the actual segment size.
///
/// This is generally expected to be the file size to map. It's
- /// provided mainly for diagnose an testing purposes; the application
+ /// provided mainly for diagnosis and testing purposes; the application
/// shouldn't rely on specific return values of this method.
///
/// \throw None
@@ -183,9 +183,9 @@ public:
///
/// This method goes over all pages of the underlying mapped memory
/// segment, and returns the sum of the value of the first byte of each
- /// page (ignoring any possible overflow). It only proves weak integrity
+ /// page (wrapping around upon overflow). It only proves weak integrity
/// of the file contents, but can run fast enough and will ensure all
- /// pages are actually on memory. The latter property will be useful
+ /// pages are actually in memory. The latter property will be useful
/// if the application cannot allow the initial page fault overhead.
///
/// \throw None
More information about the bind10-changes
mailing list