BIND 10 trac2387, updated. 3c704fca950603ec97ad259462500fe6fbd549c9 [2387] suggested editorial cleanups to doxygen doc: make it formal and unified.
BIND 10 source code commits
bind10-changes at lists.isc.org
Tue Apr 9 17:07:24 UTC 2013
The branch, trac2387 has been updated
via 3c704fca950603ec97ad259462500fe6fbd549c9 (commit)
from f8205314f85fa56bd7a8b783764c9e4ef050ad6c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3c704fca950603ec97ad259462500fe6fbd549c9
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Tue Apr 9 10:06:30 2013 -0700
[2387] suggested editorial cleanups to doxygen doc: make it formal and unified.
-----------------------------------------------------------------------
Summary of changes:
src/lib/dns/rdata/generic/dnskey_48.cc | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/dns/rdata/generic/dnskey_48.cc b/src/lib/dns/rdata/generic/dnskey_48.cc
index 0a829ed..43ba8e5 100644
--- a/src/lib/dns/rdata/generic/dnskey_48.cc
+++ b/src/lib/dns/rdata/generic/dnskey_48.cc
@@ -63,10 +63,13 @@ struct DNSKEYImpl {
/// The Protocol and Algorithm fields must be within their valid
/// ranges. The Public Key field must be present and must contain a
/// Base64 encoding of the public key. Whitespace is allowed within the
-/// Base64 text. It is okay for the key data to be missing. BIND 9 seems
-/// to accept such cases. What we should do could be debatable, but
-/// since this field is algorithm dependent and our implementation
-/// doesn't reject unknown algorithms, we are lenient here.
+/// Base64 text.
+///
+/// It is okay for the key data to be missing. Note: BIND 9 also accepts
+/// DNSKEY missing key data. While the RFC is silent in this case, and it
+/// may be debatable what an implementation should do, but since this field
+/// is algorithm dependent and this implementations doesn't reject unknown
+/// algorithms, it's lenient here.
///
/// \throw InvalidRdataText if any fields are out of their valid range,
/// or are incorrect.
@@ -105,10 +108,8 @@ DNSKEY::DNSKEY(const std::string& dnskey_str) :
/// The passed buffer must contain a valid DNSKEY RDATA.
///
/// The Protocol and Algorithm fields are not checked for unknown
-/// values. It is okay for the key data to be missing. BIND 9 seems to
-/// accept such cases. What we should do could be debatable, but since
-/// this field is algorithm dependent and our implementation doesn't
-/// reject unknown algorithms, we are lenient here.
+/// values. It is okay for the key data to be missing (see the description
+/// of the constructor from string).
DNSKEY::DNSKEY(InputBuffer& buffer, size_t rdata_len) :
impl_(NULL)
{
More information about the bind10-changes
mailing list