BIND 10 trac2831, updated. c936d8ec97816a35aafd54aa4c06fb8e5b5689eb [2831] Use ASSERT_NE with pointer value

BIND 10 source code commits bind10-changes at lists.isc.org
Fri Apr 12 14:20:03 UTC 2013


The branch, trac2831 has been updated
       via  c936d8ec97816a35aafd54aa4c06fb8e5b5689eb (commit)
      from  c1465e69b3d272bf4867d99e47c63659f41c4db3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c936d8ec97816a35aafd54aa4c06fb8e5b5689eb
Author: Mukund Sivaraman <muks at isc.org>
Date:   Fri Apr 12 19:49:46 2013 +0530

    [2831] Use ASSERT_NE with pointer value
    
    Boolean testing also works, but in the test it's easier to remember
    that it's a pointer.

-----------------------------------------------------------------------

Summary of changes:
 .../util/tests/memory_segment_mapped_unittest.cc   |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-----------------------------------------------------------------------
diff --git a/src/lib/util/tests/memory_segment_mapped_unittest.cc b/src/lib/util/tests/memory_segment_mapped_unittest.cc
index 1931bd8..2244242 100644
--- a/src/lib/util/tests/memory_segment_mapped_unittest.cc
+++ b/src/lib/util/tests/memory_segment_mapped_unittest.cc
@@ -274,7 +274,7 @@ checkNamedData(const std::string& name, const std::vector<uint8_t>& data,
     scoped_ptr<MemorySegmentMapped> segment_ro(
         new MemorySegmentMapped(mapped_file));
     void* dp2 = segment_ro->getNamedAddress(name.c_str());
-    ASSERT_TRUE(dp2);
+    ASSERT_NE(static_cast<void*>(NULL), dp2);
     EXPECT_NE(dp, dp2);
     EXPECT_EQ(0, std::memcmp(dp2, &data[0], data.size()));
     segment_ro.reset();



More information about the bind10-changes mailing list