BIND 10 trac2856, updated. e3e92f0134210e040c537753fb32e36679f4b1b0 [2856] Add a comment about add_reader() in states other than READY
BIND 10 source code commits
bind10-changes at lists.isc.org
Fri Aug 2 08:24:23 UTC 2013
The branch, trac2856 has been updated
via e3e92f0134210e040c537753fb32e36679f4b1b0 (commit)
from 786a742bc321666586ee923cf15e2d2624ddee42 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e3e92f0134210e040c537753fb32e36679f4b1b0
Author: Mukund Sivaraman <muks at isc.org>
Date: Fri Aug 2 13:54:10 2013 +0530
[2856] Add a comment about add_reader() in states other than READY
-----------------------------------------------------------------------
Summary of changes:
src/lib/python/isc/memmgr/datasrc_info.py | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/memmgr/datasrc_info.py b/src/lib/python/isc/memmgr/datasrc_info.py
index 9b1516b..db4a515 100644
--- a/src/lib/python/isc/memmgr/datasrc_info.py
+++ b/src/lib/python/isc/memmgr/datasrc_info.py
@@ -131,7 +131,15 @@ class SegmentInfo:
that are using the "current" reader version of the segment. It
must be called by memmgr when it first gets the pre-existing
readers or when it's notified of a new reader. No state
- transition happens."""
+ transition happens.
+
+ When the SegmentInfo is not in the READY state, if memmgr gets
+ notified of a new reader (such as b10-auth) subscribing to the
+ readers group and calls add_reader(), we assume the new reader
+ is using the new mapped file and not the old one. For making
+ sure there is no race, memmgr should make SegmentInfo updates in
+ the main thread itself (which also handles communications) and
+ only have the builder in a different thread."""
if reader_session_id in self.__readers:
raise SegmentInfoError('Reader session ID is already in readers set: ' +
str(reader_session_id))
More information about the bind10-changes
mailing list