BIND 10 trac2962, updated. 2b589c6418e5882bd14bc9471d292d6fc21247d2 [2962] Touch the dependency instead of using noop

BIND 10 source code commits bind10-changes at lists.isc.org
Mon Aug 5 06:23:05 UTC 2013


The branch, trac2962 has been updated
       via  2b589c6418e5882bd14bc9471d292d6fc21247d2 (commit)
      from  35c53d9ab3422ba82ebd2c4f9afb73f1a5dc58dc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2b589c6418e5882bd14bc9471d292d6fc21247d2
Author: Mukund Sivaraman <muks at isc.org>
Date:   Mon Aug 5 11:52:06 2013 +0530

    [2962] Touch the dependency instead of using noop
    
    If the cmdctl-certfile.pem is older than cmdctl-keyfile.pem for some
    reason, make will try to run the rule every time.

-----------------------------------------------------------------------

Summary of changes:
 src/bin/cmdctl/Makefile.am |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/cmdctl/Makefile.am b/src/bin/cmdctl/Makefile.am
index 25717d6..54be50f 100644
--- a/src/bin/cmdctl/Makefile.am
+++ b/src/bin/cmdctl/Makefile.am
@@ -60,15 +60,15 @@ b10_certgen_LDFLAGS = $(BOTAN_LIBS)
 cmdctl-keyfile.pem: b10-certgen
 	./b10-certgen -q -w
 
-# Do nothing. This is a hack, as b10-certgen creates both
-# cmdctl-keyfile.pem and cmdctl-certfile.pem, and in a parallel make,
-# making these targets simultaneously may result in corrupted
-# files. With GNU make, there is a non-portable way of working around
-# this with pattern rules, but we adopt this hack instead. The downside
-# is that cmdctl-certfile.pem will not be generated if
-# cmdctl-keyfile.pem exists. See Trac ticket #2962.
+# This is a hack, as b10-certgen creates both cmdctl-keyfile.pem and
+# cmdctl-certfile.pem, and in a parallel make, making these targets
+# simultaneously may result in corrupted files. With GNU make, there is
+# a non-portable way of working around this with pattern rules, but we
+# adopt this hack instead. The downside is that cmdctl-certfile.pem will
+# not be re-generated if cmdctl-keyfile.pem exists and is older. See
+# Trac ticket #2962.
 cmdctl-certfile.pem: cmdctl-keyfile.pem
-	noop
+	touch $(builddir)/cmdctl-keyfile.pem
 
 if INSTALL_CONFIGURATIONS
 



More information about the bind10-changes mailing list