BIND 10 trac3082, updated. 04f940ed5e4f796ce09e1cf216da863a9c9a0d9d [3082] Added cppcheck suppression for the enum to be passed by reference.

[BIND 10 source code commits]

The branch, trac3082 has been updated
       via  04f940ed5e4f796ce09e1cf216da863a9c9a0d9d (commit)
      from  33edd2ed3d657798c02a75f236c087527f8137ad (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 04f940ed5e4f796ce09e1cf216da863a9c9a0d9d
Author: Marcin Siodelski <marcin at isc.org>
Date:   Fri Aug 16 13:49:11 2013 +0200

    [3082] Added cppcheck suppression for the enum to be passed by reference.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dhcp/option4_client_fqdn.cc |   10 ++++++++++
 1 file changed, 10 insertions(+)

-----------------------------------------------------------------------
diff --git a/src/lib/dhcp/option4_client_fqdn.cc b/src/lib/dhcp/option4_client_fqdn.cc
index 7aa0e81..48c057b 100644
--- a/src/lib/dhcp/option4_client_fqdn.cc
+++ b/src/lib/dhcp/option4_client_fqdn.cc
@@ -127,6 +127,11 @@ Option4ClientFqdnImpl::
 Option4ClientFqdnImpl(const uint8_t flags,
                       const Option4ClientFqdn::Rcode& rcode,
                       const std::string& domain_name,
+                      // cppcheck 1.57 complains that const enum value is not passed
+                      // by reference. Note that, it accepts the non-const enum value
+                      // to be passed by value. In both cases it is unneccessary to
+                      // pass the enum by reference.
+                      // cppcheck-suppress passedByValue
                       const Option4ClientFqdn::DomainNameType name_type)
     : flags_(flags),
       rcode1_(rcode),
@@ -189,6 +194,11 @@ Option4ClientFqdnImpl::operator=(const Option4ClientFqdnImpl& source) {
 void
 Option4ClientFqdnImpl::
 setDomainName(const std::string& domain_name,
+              // cppcheck 1.57 complains that const enum value is not passed
+              // by reference. Note that, it accepts the non-const enum
+              // to be passed by value. In both cases it is unneccessary to
+              // pass the enum by reference.
+              // cppcheck-suppress passedByValue
               const Option4ClientFqdn::DomainNameType name_type) {
     // domain-name must be trimmed. Otherwise, string comprising spaces only
     // would be treated as a fully qualified name.