BIND 10 trac2157_2, updated. 2af2991a8d5e0a5f6debff5f9105fd215803b6db [2157] add a note for TSIG and opcode to b10-auth man page

BIND 10 source code commits bind10-changes at lists.isc.org
Mon Feb 4 02:19:20 UTC 2013


The branch, trac2157_2 has been updated
       via  2af2991a8d5e0a5f6debff5f9105fd215803b6db (commit)
       via  1c470ce95278e5a67b3babfb4e7adec849053e6b (commit)
      from  93b27668a1fc63da7fd0527a04691dcd00c9e310 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2af2991a8d5e0a5f6debff5f9105fd215803b6db
Author: Yoshitaka Aharen <aharen at jprs.co.jp>
Date:   Mon Feb 4 11:08:57 2013 +0900

    [2157] add a note for TSIG and opcode to b10-auth man page

commit 1c470ce95278e5a67b3babfb4e7adec849053e6b
Author: Yoshitaka Aharen <aharen at jprs.co.jp>
Date:   Mon Feb 4 11:04:13 2013 +0900

    [2157] address occasional lettuce failure: add reply check for getstats command

-----------------------------------------------------------------------

Summary of changes:
 src/bin/auth/b10-auth.xml.pre          |    5 ++++-
 tests/lettuce/features/queries.feature |   22 ++++++++++++++++++++++
 2 files changed, 26 insertions(+), 1 deletion(-)

-----------------------------------------------------------------------
diff --git a/src/bin/auth/b10-auth.xml.pre b/src/bin/auth/b10-auth.xml.pre
index e7064bc..c0bc158 100644
--- a/src/bin/auth/b10-auth.xml.pre
+++ b/src/bin/auth/b10-auth.xml.pre
@@ -210,8 +210,11 @@
       </para>
 
       <para>
-        Request attributes except for opcode will not be counted if signature
+        Request attributes except for opcode will not be counted if TSIG
         validation failed as they are not reliable.
+        We always count opcode mainly for compatibility with BIND 9,
+        but remember that if there's any error related to TSIG, some
+        of the counted opcode may not be trustworthy.
       </para>
     </note>
 
diff --git a/tests/lettuce/features/queries.feature b/tests/lettuce/features/queries.feature
index 83e77df..d9e6c25 100644
--- a/tests/lettuce/features/queries.feature
+++ b/tests/lettuce/features/queries.feature
@@ -20,6 +20,8 @@ Feature: Querying feature
 
         When I wait for new bind10 stderr message STATS_SEND_STATISTICS_REQUEST
         And wait for new bind10 stderr message AUTH_RECEIVED_COMMAND
+        And wait for new bind10 stderr message CC_REPLY
+        And wait for new bind10 stderr message "v4":
         Then I query statistics zones of bind10 module Auth
         And last bindctl output should not contain "error"
         The statistics counters are 0 in category .Auth.zones._SERVER_
@@ -47,6 +49,8 @@ Feature: Querying feature
 
         When I wait for new bind10 stderr message STATS_SEND_STATISTICS_REQUEST
         And wait for new bind10 stderr message AUTH_RECEIVED_COMMAND
+        And wait for new bind10 stderr message CC_REPLY
+        And wait for new bind10 stderr message "v4":
         Then I query statistics zones of bind10 module Auth
         And last bindctl output should not contain "error"
         The statistics counters are 0 in category .Auth.zones._SERVER_ except for the following items
@@ -84,6 +88,8 @@ Feature: Querying feature
 
         When I wait for new bind10 stderr message STATS_SEND_STATISTICS_REQUEST
         And wait for new bind10 stderr message AUTH_RECEIVED_COMMAND
+        And wait for new bind10 stderr message CC_REPLY
+        And wait for new bind10 stderr message "v4":
         Then I query statistics zones of bind10 module Auth
         And last bindctl output should not contain "error"
         The statistics counters are 0 in category .Auth.zones._SERVER_ except for the following items
@@ -109,6 +115,8 @@ Feature: Querying feature
 
         When I wait for new bind10 stderr message STATS_SEND_STATISTICS_REQUEST
         And wait for new bind10 stderr message AUTH_RECEIVED_COMMAND
+        And wait for new bind10 stderr message CC_REPLY
+        And wait for new bind10 stderr message "v4":
         Then I query statistics zones of bind10 module Auth
         And last bindctl output should not contain "error"
         The statistics counters are 0 in category .Auth.zones._SERVER_ except for the following items
@@ -138,6 +146,8 @@ Feature: Querying feature
 
         When I wait for new bind10 stderr message STATS_SEND_STATISTICS_REQUEST
         And wait for new bind10 stderr message AUTH_RECEIVED_COMMAND
+        And wait for new bind10 stderr message CC_REPLY
+        And wait for new bind10 stderr message "v4":
         Then I query statistics zones of bind10 module Auth
         And last bindctl output should not contain "error"
         The statistics counters are 0 in category .Auth.zones._SERVER_
@@ -163,6 +173,8 @@ Feature: Querying feature
 
         When I wait for new bind10 stderr message STATS_SEND_STATISTICS_REQUEST
         And wait for new bind10 stderr message AUTH_RECEIVED_COMMAND
+        And wait for new bind10 stderr message CC_REPLY
+        And wait for new bind10 stderr message "v4":
         Then I query statistics zones of bind10 module Auth
         And last bindctl output should not contain "error"
         The statistics counters are 0 in category .Auth.zones._SERVER_ except for the following items
@@ -183,6 +195,8 @@ Feature: Querying feature
 
         When I wait for new bind10 stderr message STATS_SEND_STATISTICS_REQUEST
         And wait for new bind10 stderr message AUTH_RECEIVED_COMMAND
+        And wait for new bind10 stderr message CC_REPLY
+        And wait for new bind10 stderr message "v4":
         Then I query statistics zones of bind10 module Auth
         And last bindctl output should not contain "error"
         The statistics counters are 0 in category .Auth.zones._SERVER_
@@ -204,6 +218,8 @@ Feature: Querying feature
 
         When I wait for new bind10 stderr message STATS_SEND_STATISTICS_REQUEST
         And wait for new bind10 stderr message AUTH_RECEIVED_COMMAND
+        And wait for new bind10 stderr message CC_REPLY
+        And wait for new bind10 stderr message "v4":
         Then I query statistics zones of bind10 module Auth
         And last bindctl output should not contain "error"
         The statistics counters are 0 in category .Auth.zones._SERVER_ except for the following items
@@ -236,6 +252,8 @@ Feature: Querying feature
 
         When I wait for new bind10 stderr message STATS_SEND_STATISTICS_REQUEST
         And wait for new bind10 stderr message AUTH_RECEIVED_COMMAND
+        And wait for new bind10 stderr message CC_REPLY
+        And wait for new bind10 stderr message "v4":
         Then I query statistics zones of bind10 module Auth
         And last bindctl output should not contain "error"
         The statistics counters are 0 in category .Auth.zones._SERVER_
@@ -245,6 +263,8 @@ Feature: Querying feature
 
         When I wait for new bind10 stderr message STATS_SEND_STATISTICS_REQUEST
         And wait for new bind10 stderr message AUTH_RECEIVED_COMMAND
+        And wait for new bind10 stderr message CC_REPLY
+        And wait for new bind10 stderr message "v4":
         Then I query statistics zones of bind10 module Auth
         And last bindctl output should not contain "error"
         The statistics counters are 0 in category .Auth.zones._SERVER_ except for the following items
@@ -266,6 +286,8 @@ Feature: Querying feature
 
         When I wait for new bind10 stderr message STATS_SEND_STATISTICS_REQUEST
         And wait for new bind10 stderr message AUTH_RECEIVED_COMMAND
+        And wait for new bind10 stderr message CC_REPLY
+        And wait for new bind10 stderr message "v4":
         Then I query statistics zones of bind10 module Auth
         And last bindctl output should not contain "error"
         The statistics counters are 0 in category .Auth.zones._SERVER_ except for the following items



More information about the bind10-changes mailing list