BIND 10 trac1914, updated. 7377c385cd5b4f37024dd55919873adde82a2da8 [1924] Use the constants in default parameters too

BIND 10 source code commits bind10-changes at lists.isc.org
Mon Feb 4 16:14:48 UTC 2013


The branch, trac1914 has been updated
       via  7377c385cd5b4f37024dd55919873adde82a2da8 (commit)
      from  8adef6491ebef3e81833f3d23b334c5b4fc1f72c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7377c385cd5b4f37024dd55919873adde82a2da8
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Mon Feb 4 17:14:23 2013 +0100

    [1924] Use the constants in default parameters too

-----------------------------------------------------------------------

Summary of changes:
 src/lib/cc/session.cc            |    2 --
 src/lib/cc/session.h             |   16 ++++++++++------
 src/lib/python/isc/cc/session.py |    4 ++--
 3 files changed, 12 insertions(+), 10 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/cc/session.cc b/src/lib/cc/session.cc
index 1e71656..79b7541 100644
--- a/src/lib/cc/session.cc
+++ b/src/lib/cc/session.cc
@@ -33,8 +33,6 @@
 #include <cc/data.h>
 #include <cc/session.h>
 
-#include <util/common_defs.h>
-
 #include <cstdio>
 #include <vector>
 #include <iostream>
diff --git a/src/lib/cc/session.h b/src/lib/cc/session.h
index e0ece56..de01c09 100644
--- a/src/lib/cc/session.h
+++ b/src/lib/cc/session.h
@@ -15,14 +15,16 @@
 #ifndef ISC_SESSION_H
 #define ISC_SESSION_H 1
 
-#include <string>
+#include <cc/data.h>
+#include <cc/session_config.h>
 
-#include <boost/function.hpp>
+#include <util/common_defs.h>
 
 #include <exceptions/exceptions.h>
 
-#include <cc/data.h>
-#include <cc/session_config.h>
+#include <string>
+
+#include <boost/function.hpp>
 
 namespace asio {
 class io_service;
@@ -81,8 +83,10 @@ namespace isc {
             virtual void disconnect() = 0;
             virtual int group_sendmsg(isc::data::ConstElementPtr msg,
                                       std::string group,
-                                      std::string instance = "*",
-                                      std::string to = "*",
+                                      std::string instance =
+                                          isc::util::CC_INSTANCE_WILDCARD,
+                                      std::string to =
+                                          isc::util::CC_TO_WILDCARD,
                                       bool want_answer = false) = 0;
             virtual bool group_recvmsg(isc::data::ConstElementPtr& envelope,
                                        isc::data::ConstElementPtr& msg,
diff --git a/src/lib/python/isc/cc/session.py b/src/lib/python/isc/cc/session.py
index 8ea7fca..cfc54d9 100644
--- a/src/lib/python/isc/cc/session.py
+++ b/src/lib/python/isc/cc/session.py
@@ -257,8 +257,8 @@ class Session:
             "instance": instance,
         })
 
-    def group_sendmsg(self, msg, group, instance = "*", to = "*",
-                      want_answer=False):
+    def group_sendmsg(self, msg, group, instance=CC_INSTANCE_WILDCARD,
+                      to=CC_TO_WILDCARD, want_answer=False):
         seq = self._next_sequence()
         self.sendmsg({
             CC_HEADER_TYPE: CC_COMMAND_SEND,



More information about the bind10-changes mailing list