BIND 10 master, updated. ffd4a283b18f8eaa453712e1e615e2440b12aa0d [2225_statistics_3] change assertGreater() to assertGreaterEqual()

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Feb 6 06:56:48 UTC 2013


The branch, master has been updated
       via  ffd4a283b18f8eaa453712e1e615e2440b12aa0d (commit)
      from  936279ca980c2c2b5b711f147703665f722ffd9c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ffd4a283b18f8eaa453712e1e615e2440b12aa0d
Author: Naoki Kambe <kambe at jprs.co.jp>
Date:   Wed Feb 6 09:19:05 2013 +0900

    [2225_statistics_3] change assertGreater() to assertGreaterEqual()
    
    http://git.bind10.isc.org/~tester/builder//BIND10-cppcheck/20130129171501-FreeBSD8-amd64-GCC/logs/unittests.out
    http://git.bind10.isc.org/~tester/builder//BIND10-cppcheck/20130205115001-FreeBSD8-amd64-GCC/logs/unittests.out
    
    As the above results, on this platform, it doesn't mostly return an
    accurate float of seconds which is less than 1.0. The above failure
    happened at line 203 in counters_test.py , but also at line 142 there
    is probably the same problem.  This fix is similar to
    89fd37be8d063c6fce0fa731ab7f3ac9c45667ef.

-----------------------------------------------------------------------

Summary of changes:
 .../python/isc/statistics/tests/counters_test.py   |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/statistics/tests/counters_test.py b/src/lib/python/isc/statistics/tests/counters_test.py
index 550fd1f..2d791c4 100644
--- a/src/lib/python/isc/statistics/tests/counters_test.py
+++ b/src/lib/python/isc/statistics/tests/counters_test.py
@@ -139,9 +139,9 @@ class TestBasicMethods(unittest.TestCase):
             counters._get_counter(self.counters._statistics._data,
                                  counter_name),
             concurrency * number)
-        self.assertGreater(
+        self.assertGreaterEqual(
             counters._get_counter(self.counters._statistics._data,
-                                 timer_name), 0)
+                                 timer_name), 0.0)
 
     def test_concat(self):
         # only strings
@@ -200,7 +200,7 @@ class BaseTestCounters():
             if name.find('time_to_') == 0:
                 self.counters.start_timer(*args)
                 self.counters.stop_timer(*args)
-                self.assertGreater(self.counters.get(*args), 0)
+                self.assertGreaterEqual(self.counters.get(*args), 0.0)
                 sec = self.counters.get(*args)
                 for zone_str in (self._entire_server, TEST_ZONE_NAME_STR):
                     isc.cc.data.set(self._statistics_data,



More information about the bind10-changes mailing list