BIND 10 trac1924, updated. c45a2112f2ecec8f96e7810f4f5dfd7d46043e4a [1924] Return failure explicitly

[BIND 10 source code commits]

The branch, trac1924 has been updated
       via  c45a2112f2ecec8f96e7810f4f5dfd7d46043e4a (commit)
       via  e15ccdfa19349060a082add1541e553e4b9d1d4b (commit)
      from  2832cc07032db112749999848d8506febdb44e78 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c45a2112f2ecec8f96e7810f4f5dfd7d46043e4a
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Fri Feb 8 10:43:07 2013 +0100

    [1924] Return failure explicitly

commit e15ccdfa19349060a082add1541e553e4b9d1d4b
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Fri Feb 8 10:42:32 2013 +0100

    [1924] (minor) Comment tweaks

-----------------------------------------------------------------------

Summary of changes:
 src/bin/msgq/msgq.py.in         |    4 ++--
 src/bin/msgq/tests/msgq_test.py |    6 +++++-
 2 files changed, 7 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/bin/msgq/msgq.py.in b/src/bin/msgq/msgq.py.in
index a555631..d5631f8 100755
--- a/src/bin/msgq/msgq.py.in
+++ b/src/bin/msgq/msgq.py.in
@@ -567,8 +567,8 @@ class MsgQ:
             CC_HEADER_REPLY not in routing:
             # We have no recipients. But the sender insists on a reply
             # (and the message isn't a reply itself). We need to send
-            # an error to satisfy the senders hunger for response, since
-            # nobody else will do that.
+            # an error to satisfy the request, since there's nobody
+            # else who can.
             #
             # We omit the replies on purpose. The recipient might generate
             # the response by copying and mangling the header of incoming
diff --git a/src/bin/msgq/tests/msgq_test.py b/src/bin/msgq/tests/msgq_test.py
index 4f5dae1..cf2e7dd 100644
--- a/src/bin/msgq/tests/msgq_test.py
+++ b/src/bin/msgq/tests/msgq_test.py
@@ -171,7 +171,8 @@ class MsgQTest(unittest.TestCase):
         of existence of the recipient, addressing schemes, want_answer
         header and the reply header. It is not needed, these should
         be mostly independant (eg. if the recipient is missing, it
-        shouldn't matter why to the handling of the reply header). If
+        shouldn't matter by which means it was discovered the recipient
+        is missing to how we hendle the value in reply header). If
         we included everything, the test would have too many scenarios.
         """
         sent_messages = []
@@ -259,6 +260,7 @@ class MsgQTest(unittest.TestCase):
         self.assertEqual(2, sent_messages[0][0]) # The recipient
         self.assertEqual((routing, data), self.parse_msg(sent_messages[0][1]))
         sent_messages = []
+
         # If an attempt to send fails, consider it no recipient.
         def fail_send_prepared_msg(socket, msg):
             '''
@@ -266,6 +268,8 @@ class MsgQTest(unittest.TestCase):
             usual mock, so the errors or other messages can be sent.
             '''
             self.__msgq.send_prepared_msg = fake_send_prepared_msg
+            return False
+
         self.__msgq.send_prepared_msg = fail_send_prepared_msg
         self.__msgq.process_command_send(sender, routing, data)
         self.assertEqual(1, len(sent_messages))