BIND 10 trac2673, updated. 1eef52e751a97720ba679256b24b2c90ed98b5fd [2673] Correct use of wrong variable in unit test
BIND 10 source code commits
bind10-changes at lists.isc.org
Mon Feb 11 12:28:32 UTC 2013
The branch, trac2673 has been updated
via 1eef52e751a97720ba679256b24b2c90ed98b5fd (commit)
from c274bccc9c7ab201ac00f09896b2511791556278 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 1eef52e751a97720ba679256b24b2c90ed98b5fd
Author: Stephen Morris <stephen at isc.org>
Date: Mon Feb 11 12:26:12 2013 +0000
[2673] Correct use of wrong variable in unit test
-----------------------------------------------------------------------
Summary of changes:
src/bin/dhcp4/tests/dhcp4_srv_unittest.cc | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/dhcp4/tests/dhcp4_srv_unittest.cc b/src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
index 4971ff4..c938155 100644
--- a/src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
+++ b/src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
@@ -234,11 +234,13 @@ public:
/// Check that address was returned from proper range, that its lease
/// lifetime is correct, that T1 and T2 are returned properly
/// @param rsp response to be checked
- /// @param subnet subnet that should be used to verify assigned address and options
+ /// @param subnet subnet that should be used to verify assigned address
+ /// and options
/// @param t1_mandatory is T1 mandatory?
/// @param t2_mandatory is T2 mandatory?
void checkAddressParams(const Pkt4Ptr& rsp, const SubnetPtr subnet,
- bool t1_mandatory = false, bool /* t2_mandatory */ = false) {
+ bool t1_mandatory = false,
+ bool t2_mandatory = false) {
// Technically inPool implies inRange, but let's be on the safe
// side and check both.
@@ -268,7 +270,7 @@ public:
if (opt) {
EXPECT_EQ(opt->getUint32(), subnet->getT2());
} else {
- if (t1_mandatory) {
+ if (t2_mandatory) {
ADD_FAILURE() << "Required T2 option missing";
}
}
More information about the bind10-changes
mailing list