BIND 10 trac2281, updated. 67940bdbff79a551466de411f4ed3126a254888e [2281] Add comments on use of static datasrc instead of memory datasrc in tests

BIND 10 source code commits bind10-changes at lists.isc.org
Wed Feb 13 06:03:02 UTC 2013


The branch, trac2281 has been updated
       via  67940bdbff79a551466de411f4ed3126a254888e (commit)
      from  8e33f9e96aa79b1f99828c063cab84328ce3f248 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 67940bdbff79a551466de411f4ed3126a254888e
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Feb 13 11:32:37 2013 +0530

    [2281] Add comments on use of static datasrc instead of memory datasrc in tests

-----------------------------------------------------------------------

Summary of changes:
 src/lib/python/isc/datasrc/tests/datasrc_test.py   |    8 +++++++-
 .../python/isc/datasrc/tests/zone_loader_test.py   |    9 +++++++--
 2 files changed, 14 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/datasrc/tests/datasrc_test.py b/src/lib/python/isc/datasrc/tests/datasrc_test.py
index cf240ce..abc9739 100644
--- a/src/lib/python/isc/datasrc/tests/datasrc_test.py
+++ b/src/lib/python/isc/datasrc/tests/datasrc_test.py
@@ -563,7 +563,10 @@ class DataSrcUpdater(unittest.TestCase):
         self.assertEqual(updater_refs, sys.getrefcount(updater))
 
     def test_two_modules(self):
-        # load two modules, and check if they don't interfere
+        # load two modules, and check if they don't interfere; as the
+        # memory datasource module no longer exists, we check the static
+        # datasource instead (as that uses the memory datasource
+        # anyway).
         dsc_static = isc.datasrc.DataSourceClient("static", STATIC_ZONE_CONFIG)
         dsc_sql = isc.datasrc.DataSourceClient("sqlite3", READ_ZONE_DB_CONFIG)
 
@@ -721,6 +724,9 @@ class DataSrcUpdater(unittest.TestCase):
         self.assertTrue(dsc.delete_zone(zone_name))
 
     def test_create_zone_not_implemented(self):
+        # As the memory datasource module no longer exists, we check the
+        # static datasource instead (as that uses the memory datasource
+        # anyway).
         dsc = isc.datasrc.DataSourceClient("static", STATIC_ZONE_CONFIG)
         self.assertRaises(isc.datasrc.NotImplemented, dsc.create_zone,
                           isc.dns.Name("example.com"))
diff --git a/src/lib/python/isc/datasrc/tests/zone_loader_test.py b/src/lib/python/isc/datasrc/tests/zone_loader_test.py
index 9f4098e..e437e36 100644
--- a/src/lib/python/isc/datasrc/tests/zone_loader_test.py
+++ b/src/lib/python/isc/datasrc/tests/zone_loader_test.py
@@ -216,8 +216,13 @@ class ZoneLoaderTests(unittest.TestCase):
                           self.client, zone_name, self.source_client)
 
     def test_no_ds_load_support(self):
-        # This may change in the future, but atm, the static ds does
-        # not support the API the zone loader uses (it has direct load calls)
+        # As the memory datasource module no longer exists, we check the
+        # static datasource instead (as that uses the memory datasource
+        # anyway).
+        #
+        # This may change in the future, but ATM, the static ds does not
+        # support the API the zone loader uses (it has direct load
+        # calls).
         inmem_client = isc.datasrc.DataSourceClient('static',
                                                     STATIC_ZONE_CONFIG);
         self.assertRaises(isc.datasrc.NotImplemented,



More information about the bind10-changes mailing list