BIND 10 trac2676, updated. 59651a74809b06c0228d2b39202335fffaee048e [2676] (minor) Explain a FIXME comment

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Feb 19 10:04:32 UTC 2013


The branch, trac2676 has been updated
       via  59651a74809b06c0228d2b39202335fffaee048e (commit)
      from  4d5d7d6e423cb6e46a9f4acfde4e8ebf434951d2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 59651a74809b06c0228d2b39202335fffaee048e
Author: Michal 'vorner' Vaner <michal.vaner at nic.cz>
Date:   Tue Feb 19 11:04:07 2013 +0100

    [2676] (minor) Explain a FIXME comment

-----------------------------------------------------------------------

Summary of changes:
 src/bin/zonemgr/zonemgr.py.in |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-----------------------------------------------------------------------
diff --git a/src/bin/zonemgr/zonemgr.py.in b/src/bin/zonemgr/zonemgr.py.in
index 94e93f8..59900c4 100755
--- a/src/bin/zonemgr/zonemgr.py.in
+++ b/src/bin/zonemgr/zonemgr.py.in
@@ -279,7 +279,10 @@ class ZonemgrRefresh:
         """Send command between modules."""
         try:
             self._mccs.rpc_call(command_name, module_name, params=params)
-        except socket.error: # FIXME: WTF?
+        except socket.error:
+            # FIXME: WTF? Where does socket.error come from? And how do we ever
+            # dare ignore such serious error? It can only be broken link to
+            # msgq, we need to terminate then.
             logger.error(ZONEMGR_SEND_FAIL, module_name)
         except (isc.cc.session.SessionTimeout, isc.config.RPCError):
             pass        # for now we just ignore the failure



More information about the bind10-changes mailing list