BIND 10 trac2524, updated. 9fbb0ae95365974d80a87704f64d6e4907dcb52e [2524] Change to comments after review.

BIND 10 source code commits bind10-changes at lists.isc.org
Thu Jan 3 19:28:17 UTC 2013


The branch, trac2524 has been updated
       via  9fbb0ae95365974d80a87704f64d6e4907dcb52e (commit)
      from  62794b031c00451e7bec0a0b94b4a2dadb42ae0e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9fbb0ae95365974d80a87704f64d6e4907dcb52e
Author: Stephen Morris <stephen at isc.org>
Date:   Thu Jan 3 19:27:46 2013 +0000

    [2524] Change to comments after review.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dhcpsrv/lease_mgr_factory.cc |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dhcpsrv/lease_mgr_factory.cc b/src/lib/dhcpsrv/lease_mgr_factory.cc
index 23ba12f..9fd276d 100644
--- a/src/lib/dhcpsrv/lease_mgr_factory.cc
+++ b/src/lib/dhcpsrv/lease_mgr_factory.cc
@@ -74,21 +74,23 @@ LeaseMgrFactory::parse(const std::string& dbaccess) {
 
 std::string
 LeaseMgrFactory::redactedAccessString(const LeaseMgr::ParameterMap& parameters) {
-    // Reconstruct the access string
-    std::string access = "";
+    // Reconstruct the access string: start of with an empty string, then
+    // work through all the parameters in the original string and add them.
+    std::string access;
     for (LeaseMgr::ParameterMap::const_iterator i = parameters.begin();
          i != parameters.end(); ++i) {
 
-        // Separate second and subsequent tokens.
+        // Separate second and subsequent tokens are preceded by a space.
         if (!access.empty()) {
             access += " ";
         }
 
-        // Append name of parameter
+        // Append name of parameter...
         access += i->first;
         access += "=";
 
-        // Redact the password
+        // ... and the value, except in the case of the password, where a
+        // redacted value is appended.
         if (i->first == std::string("password")) {
             access += "*****";
         } else {



More information about the bind10-changes mailing list