BIND 10 trac2435, updated. 716eeec4d6fc5d5db9a8dba8b242fd541380a92f [2435] Remove the DatasrcIter implementation for now

[BIND 10 source code commits]

The branch, trac2435 has been updated
       via  716eeec4d6fc5d5db9a8dba8b242fd541380a92f (commit)
       via  a69acbd2f9dde5eb533b95ef0d538495e733dcd2 (commit)
       via  173f076fb4c6d687de433786e0cf1ffd53fb95b2 (commit)
       via  88639855c40c5a935126bb44d49883e4f452740b (commit)
      from  70cb4d4886e27554e9a9e8751089ba8bd4678701 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 716eeec4d6fc5d5db9a8dba8b242fd541380a92f
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jan 9 10:47:02 2013 +0530

    [2435] Remove the DatasrcIter implementation for now
    
    It is not complete and unused, as the getBeginning() and getEnd()
    methods simply throw now.

commit a69acbd2f9dde5eb533b95ef0d538495e733dcd2
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jan 9 10:44:26 2013 +0530

    [2435] Describe that a reference to the updater is kept

commit 173f076fb4c6d687de433786e0cf1ffd53fb95b2
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jan 9 10:40:51 2013 +0530

    [2435] Rename DsIter iterator class to DatasrcIter

commit 88639855c40c5a935126bb44d49883e4f452740b
Author: Mukund Sivaraman <muks at isc.org>
Date:   Wed Jan 9 10:39:35 2013 +0530

    [2435] Fix copyright year of files

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/rrset_collection.cc |    2 +-
 src/lib/datasrc/rrset_collection.h  |   32 +++++++++-----------------------
 2 files changed, 10 insertions(+), 24 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/rrset_collection.cc b/src/lib/datasrc/rrset_collection.cc
index e9a5fd8..51fa97c 100644
--- a/src/lib/datasrc/rrset_collection.cc
+++ b/src/lib/datasrc/rrset_collection.cc
@@ -1,4 +1,4 @@
-// Copyright (C) 2012  Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2013  Internet Systems Consortium, Inc. ("ISC")
 //
 // Permission to use, copy, modify, and/or distribute this software for any
 // purpose with or without fee is hereby granted, provided that the above
diff --git a/src/lib/datasrc/rrset_collection.h b/src/lib/datasrc/rrset_collection.h
index c8a6add..6ad494a 100644
--- a/src/lib/datasrc/rrset_collection.h
+++ b/src/lib/datasrc/rrset_collection.h
@@ -1,4 +1,4 @@
-// Copyright (C) 2012  Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2013  Internet Systems Consortium, Inc. ("ISC")
 //
 // Permission to use, copy, modify, and/or distribute this software for any
 // purpose with or without fee is hereby granted, provided that the above
@@ -26,6 +26,12 @@ namespace datasrc {
 class RRsetCollection : public isc::dns::RRsetCollectionBase {
 public:
     /// \brief Constructor.
+    ///
+    /// A reference to the \c updater (via \c shared_ptr) is taken when
+    /// the collection is constructed. As long as the collection object
+    /// is alive, the reference to the updater is kept and it cannot be
+    /// destroyed by the client.
+    ///
     /// \param updater The ZoneUpdater to wrap around.
     RRsetCollection(ZoneUpdaterPtr updater) :
         updater_(updater)
@@ -52,28 +58,8 @@ private:
     ZoneUpdaterPtr updater_;
 
 protected:
-    class DsIter : public RRsetCollectionBase::Iter {
-    public:
-        DsIter()
-        {}
-
-        virtual const isc::dns::AbstractRRset& getValue() {
-            isc_throw(isc::NotImplemented, "This method is not implemented.");
-        }
-
-        virtual IterPtr getNext() {
-            isc_throw(isc::NotImplemented, "This method is not implemented.");
-        }
-
-        virtual bool equals(Iter& other) {
-            const DsIter* other_real = dynamic_cast<DsIter*>(&other);
-            if (other_real == NULL) {
-                return (false);
-            }
-
-            isc_throw(isc::NotImplemented, "This method is not implemented.");
-        }
-    };
+    // TODO: RRsetCollectionBase::Iter is not implemented and the
+    // following two methods just throw.
 
     virtual RRsetCollectionBase::IterPtr getBeginning();
     virtual RRsetCollectionBase::IterPtr getEnd();