BIND 10 trac2571_commit_log_fix, updated. 5e1b58d8df60d78e58a883832aea8dd5a9282c82 [2571] Explain unit test for character 255.

BIND 10 source code commits bind10-changes at lists.isc.org
Mon Jan 14 15:54:04 UTC 2013


The branch, trac2571_commit_log_fix has been updated
       via  5e1b58d8df60d78e58a883832aea8dd5a9282c82 (commit)
      from  b88bb61f7547158719b8329c8ddf7b8e36ef2185 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5e1b58d8df60d78e58a883832aea8dd5a9282c82
Author: Shane Kerr <shane at isc.org>
Date:   Mon Jan 14 16:51:21 2013 +0100

    [2571] Explain unit test for character 255.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/cc/tests/data_unittests.cc |    3 +++
 1 file changed, 3 insertions(+)

-----------------------------------------------------------------------
diff --git a/src/lib/cc/tests/data_unittests.cc b/src/lib/cc/tests/data_unittests.cc
index 9c41a31..9f015d2 100644
--- a/src/lib/cc/tests/data_unittests.cc
+++ b/src/lib/cc/tests/data_unittests.cc
@@ -91,6 +91,9 @@ TEST(Element, from_and_to_json) {
     sv.push_back("-1");
     sv.push_back("-1.234");
     sv.push_back("-123.456");
+    // We should confirm that our string handling is 8-bit clean.
+    // At one point we were using char-length data and comparing to EOF,
+    // which means that character '\xFF' would not parse properly.
     sv.push_back("\"\xFF\"");
 
     BOOST_FOREACH(const std::string& s, sv) {



More information about the bind10-changes mailing list