BIND 10 trac2498, updated. 9a0d024c97ba896c577d59db04a0337d3c70221a [2498] Add another HINFO test
BIND 10 source code commits
bind10-changes at lists.isc.org
Mon Jan 14 16:11:33 UTC 2013
The branch, trac2498 has been updated
via 9a0d024c97ba896c577d59db04a0337d3c70221a (commit)
from 7cbed6378d88f921cf33b12d18d78e56400b4702 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 9a0d024c97ba896c577d59db04a0337d3c70221a
Author: Jelte Jansen <jelte at isc.org>
Date: Mon Jan 14 17:08:28 2013 +0100
[2498] Add another HINFO test
and remove some code that should not have been committed
-----------------------------------------------------------------------
Summary of changes:
src/lib/dns/rdata/generic/hinfo_13.cc | 4 ----
src/lib/dns/rdata/generic/hinfo_13.h | 1 -
src/lib/dns/tests/rdata_hinfo_unittest.cc | 2 ++
3 files changed, 2 insertions(+), 5 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/dns/rdata/generic/hinfo_13.cc b/src/lib/dns/rdata/generic/hinfo_13.cc
index 0764951..319ec7d 100644
--- a/src/lib/dns/rdata/generic/hinfo_13.cc
+++ b/src/lib/dns/rdata/generic/hinfo_13.cc
@@ -155,9 +155,5 @@ HINFO::toWireHelper(T& outputer) const {
outputer.writeData(&impl_->os[0], impl_->os.size());
}
-void HINFO::ptr() const {
- std::cout << "[XX] PTR: " << impl_.get() << std::endl;
-}
-
// END_RDATA_NAMESPACE
// END_ISC_NAMESPACE
diff --git a/src/lib/dns/rdata/generic/hinfo_13.h b/src/lib/dns/rdata/generic/hinfo_13.h
index a2018f5..60404c9 100644
--- a/src/lib/dns/rdata/generic/hinfo_13.h
+++ b/src/lib/dns/rdata/generic/hinfo_13.h
@@ -52,7 +52,6 @@ public:
const std::string getCPU() const;
const std::string getOS() const;
- void ptr() const;
private:
/// Helper template function for toWire()
///
diff --git a/src/lib/dns/tests/rdata_hinfo_unittest.cc b/src/lib/dns/tests/rdata_hinfo_unittest.cc
index 0bea477..7be2cb6 100644
--- a/src/lib/dns/tests/rdata_hinfo_unittest.cc
+++ b/src/lib/dns/tests/rdata_hinfo_unittest.cc
@@ -107,6 +107,8 @@ TEST_F(Rdata_HINFO_Test, toText) {
EXPECT_EQ("\"a\" \"b\"", HINFO("a b").toText());
// will not add additional quotes
EXPECT_EQ("\"a\" \"b\"", HINFO("\"a\" \"b\"").toText());
+ // And make sure escaped quotes and spaces are left intact
+ EXPECT_EQ("\"a\\\"\" \"b c\"", HINFO("\"a\\\"\" \"b c\"").toText());
}
TEST_F(Rdata_HINFO_Test, toWire) {
More information about the bind10-changes
mailing list