BIND 10 trac2435, updated. 09c47d4fef3388cd1aa2aa7db402da67c4968d3f [2435] Elaborate note about unsupported RRTypes

[BIND 10 source code commits]

The branch, trac2435 has been updated
       via  09c47d4fef3388cd1aa2aa7db402da67c4968d3f (commit)
       via  48892724360a9c706de8c2ffaa5099dc1da211ea (commit)
      from  2b05b3926ac85363b1063a12c9ac8d0ac9cda3de (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 09c47d4fef3388cd1aa2aa7db402da67c4968d3f
Author: Mukund Sivaraman <muks at isc.org>
Date:   Tue Jan 15 13:45:40 2013 +0530

    [2435] Elaborate note about unsupported RRTypes

commit 48892724360a9c706de8c2ffaa5099dc1da211ea
Author: Mukund Sivaraman <muks at isc.org>
Date:   Tue Jan 15 13:30:37 2013 +0530

    [2435] Add a note that some records may not be found by the datasrc RRsetCollection

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/rrset_collection_base.h    |    4 ++++
 src/lib/datasrc/tests/database_unittest.cc |    7 +++----
 src/lib/dns/rrset_collection_base.h        |    8 +++++++-
 3 files changed, 14 insertions(+), 5 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/rrset_collection_base.h b/src/lib/datasrc/rrset_collection_base.h
index 7a414df..c02df9a 100644
--- a/src/lib/datasrc/rrset_collection_base.h
+++ b/src/lib/datasrc/rrset_collection_base.h
@@ -56,6 +56,10 @@ public:
     /// given \c name, \c rrclass and \c rrtype.  If no matching RRset
     /// is found, \c NULL is returned.
     ///
+    /// Note that not all records added through the updater may
+    /// necessarily be found by this method, such as RRs subject to
+    /// DNAME substitution.
+    ///
     /// \throw isc::dns::RRsetCollectionError if \c find() results in
     /// some underlying datasrc error, or if \c disable() was called.
     ///
diff --git a/src/lib/datasrc/tests/database_unittest.cc b/src/lib/datasrc/tests/database_unittest.cc
index 0ca5a02..94d90b5 100644
--- a/src/lib/datasrc/tests/database_unittest.cc
+++ b/src/lib/datasrc/tests/database_unittest.cc
@@ -4234,12 +4234,11 @@ TYPED_TEST(RRsetCollectionTest, find) {
                                   this->qclass_, RRType::AAAA());
     EXPECT_FALSE(rrset);
 
-    // TODO: "below.dname.example.org." with type A does not return the
-    // record (see top of file). It needs to be checked if this is what
-    // we want.
+    // "below.dname.example.org." with type A does not return the record
+    // (see top of file). See \c isc::datasrc::RRsetCollectionBase::find()
+    // documentation for details.
     rrset = this->collection.find(Name("below.dname.example.org"),
                                   this->qclass_, RRType::A());
-    // Is this correct behavior?
     EXPECT_FALSE(rrset);
 
     // With the FIND_GLUE_OK option passed to ZoneFinder's find(),
diff --git a/src/lib/dns/rrset_collection_base.h b/src/lib/dns/rrset_collection_base.h
index c2536da..2da03d9 100644
--- a/src/lib/dns/rrset_collection_base.h
+++ b/src/lib/dns/rrset_collection_base.h
@@ -58,7 +58,13 @@ public:
     /// is found, \c NULL is returned.
     ///
     /// This method's implementations currently are not specified to
-    /// handle \c RRTypes such as RRSIG, NSEC3, ANY, or AXFR.
+    /// handle \c RRTypes such as RRSIG and NSEC3. RRSIGs are attached
+    /// to their corresponding \c RRset and it is not straightforward to
+    /// search for them. Searching for RRSIGs will return \c false
+    /// always. Support for RRSIGs may be added in the future.
+    ///
+    /// Non-concrete types such as ANY and AXFR are unsupported and will
+    /// return \c false always.
     ///
     /// \throw RRsetCollectionError if find() results in some
     /// implementation-specific error.