BIND 10 trac2559, updated. aad83b6edde86e70a460cdf887b985841c161016 [2559] Address review comments
BIND 10 source code commits
bind10-changes at lists.isc.org
Fri Jan 18 18:27:57 UTC 2013
The branch, trac2559 has been updated
via aad83b6edde86e70a460cdf887b985841c161016 (commit)
from 88d25efcbc3e7b6a8fe7dea5c78e40115be1b1f4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit aad83b6edde86e70a460cdf887b985841c161016
Author: Stephen Morris <stephen at isc.org>
Date: Fri Jan 18 18:27:32 2013 +0000
[2559] Address review comments
-----------------------------------------------------------------------
Summary of changes:
src/bin/dhcp4/config_parser.cc | 3 ---
src/bin/dhcp6/config_parser.cc | 3 ---
src/lib/dhcpsrv/tests/dbaccess_parser_unittest.cc | 4 ++++
3 files changed, 4 insertions(+), 6 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/dhcp4/config_parser.cc b/src/bin/dhcp4/config_parser.cc
index 9595c22..c067a6f 100644
--- a/src/bin/dhcp4/config_parser.cc
+++ b/src/bin/dhcp4/config_parser.cc
@@ -38,9 +38,6 @@ using namespace isc::asiolink;
namespace {
-/// @brief auxiliary type used for storing element name and its parser
-typedef pair<string, ConstElementPtr> ConfigPair;
-
/// @brief a factory method that will create a parser for a given element name
typedef isc::dhcp::DhcpConfigParser* ParserFactory(const std::string& config_id);
diff --git a/src/bin/dhcp6/config_parser.cc b/src/bin/dhcp6/config_parser.cc
index a063e72..1ded503 100644
--- a/src/bin/dhcp6/config_parser.cc
+++ b/src/bin/dhcp6/config_parser.cc
@@ -47,9 +47,6 @@ using namespace isc::asiolink;
namespace {
-/// @brief Auxiliary type used for storing an element name and its parser.
-typedef pair<string, ConstElementPtr> ConfigPair;
-
/// @brief Factory method that will create a parser for a given element name
typedef isc::dhcp::DhcpConfigParser* ParserFactory(const std::string& config_id);
diff --git a/src/lib/dhcpsrv/tests/dbaccess_parser_unittest.cc b/src/lib/dhcpsrv/tests/dbaccess_parser_unittest.cc
index 61597dc..05c0743 100644
--- a/src/lib/dhcpsrv/tests/dbaccess_parser_unittest.cc
+++ b/src/lib/dhcpsrv/tests/dbaccess_parser_unittest.cc
@@ -177,6 +177,10 @@ public:
virtual ~TestDbAccessParser()
{}
+ /// Allow use of superclass's protected functions.
+ using DbAccessParser::getDbAccessParameters;
+ using DbAccessParser::getDbAccessString;
+
/// @brief Get database access parameters
///
/// Used in testing to check that the configuration information has been
More information about the bind10-changes
mailing list