BIND 10 trac2856, updated. fd38783ce713c1ee718805cd5cc7bd33b07dbc4c [2856] Check that old_readers is untouched by add_reader()

[BIND 10 source code commits]

The branch, trac2856 has been updated
       via  fd38783ce713c1ee718805cd5cc7bd33b07dbc4c (commit)
       via  d474c8d06214a2ef3dfc991dbd7b73dbfa6572b8 (commit)
      from  e7855781ad5d287d91c883143bbe2552bcc29f8d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fd38783ce713c1ee718805cd5cc7bd33b07dbc4c
Author: Mukund Sivaraman <muks at isc.org>
Date:   Mon Jul 8 17:41:10 2013 +0530

    [2856] Check that old_readers is untouched by add_reader()

commit d474c8d06214a2ef3dfc991dbd7b73dbfa6572b8
Author: Mukund Sivaraman <muks at isc.org>
Date:   Mon Jul 8 17:40:09 2013 +0530

    [2856] Fix exception messages

-----------------------------------------------------------------------

Summary of changes:
 src/lib/python/isc/memmgr/datasrc_info.py          |    6 +++---
 .../python/isc/memmgr/tests/datasrc_info_tests.py  |    4 ++++
 2 files changed, 7 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/python/isc/memmgr/datasrc_info.py b/src/lib/python/isc/memmgr/datasrc_info.py
index 9d329a8..c7ad598 100644
--- a/src/lib/python/isc/memmgr/datasrc_info.py
+++ b/src/lib/python/isc/memmgr/datasrc_info.py
@@ -113,10 +113,10 @@ class SegmentInfo:
                                    'incorrect state: ' + str(self.__state))
         if reader_session_id not in self.__old_readers:
             raise SegmentInfoError('Reader session ID is not in old readers set: ' +
-                                   reader_session_id)
+                                   str(reader_session_id))
         if reader_session_id in self.__readers:
             raise SegmentInfoError('Reader session ID is already in readers set: ' +
-                                   reader_session_id)
+                                   str(reader_session_id))
 
         self.__old_readers.remove(reader_session_id)
         self.__readers.add(reader_session_id)
@@ -136,7 +136,7 @@ class SegmentInfo:
         else:
             raise SegmentInfoError('Reader session ID is not in current ' +
                                    'readers or old readers set: ' +
-                                   reader_session_id)
+                                   str(reader_session_id))
 
     def create(type, genid, rrclass, datasrc_name, mgr_config):
         """Factory of specific SegmentInfo subclass instance based on the
diff --git a/src/lib/python/isc/memmgr/tests/datasrc_info_tests.py b/src/lib/python/isc/memmgr/tests/datasrc_info_tests.py
index b2d02d1..77470d3 100644
--- a/src/lib/python/isc/memmgr/tests/datasrc_info_tests.py
+++ b/src/lib/python/isc/memmgr/tests/datasrc_info_tests.py
@@ -99,6 +99,7 @@ class TestSegmentInfo(unittest.TestCase):
 
     def test_add_reader(self):
         self.assertSetEqual(self.__sgmt_info.get_readers(), set())
+        self.assertSetEqual(self.__sgmt_info.get_old_readers(), set())
         self.__sgmt_info.add_reader(1)
         self.assertSetEqual(self.__sgmt_info.get_readers(), {1})
         self.__sgmt_info.add_reader(3)
@@ -113,6 +114,9 @@ class TestSegmentInfo(unittest.TestCase):
         # but the existing readers must be untouched
         self.assertSetEqual(self.__sgmt_info.get_readers(), {1, 3, 2})
 
+        # none of this touches the old readers
+        self.assertSetEqual(self.__sgmt_info.get_old_readers(), set())
+
     def test_complete_update(self):
         # in READY state
         self.__si_to_ready_state()