BIND 10 trac2196, updated. 055ec496b9aaab978f83e9fb93168b0f6eabe4c1 [2196] Minor fixes (unused variables, unnecessary const and comment updates)
BIND 10 source code commits
bind10-changes at lists.isc.org
Wed Jul 17 06:45:48 UTC 2013
The branch, trac2196 has been updated
via 055ec496b9aaab978f83e9fb93168b0f6eabe4c1 (commit)
from 9b19401f4a9a0d2d81f3619b232d713dd25098d1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 055ec496b9aaab978f83e9fb93168b0f6eabe4c1
Author: Kazunori Fujiwara <fujiwara at wide.ad.jp>
Date: Wed Jul 17 15:44:52 2013 +0900
[2196] Minor fixes (unused variables, unnecessary const and comment updates)
-----------------------------------------------------------------------
Summary of changes:
src/bin/auth/statistics.cc.pre | 4 ++--
src/bin/auth/tests/statistics_unittest.cc.pre | 2 +-
src/bin/stats/stats.py.in | 2 +-
src/lib/statistics/counter.h | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/bin/auth/statistics.cc.pre b/src/bin/auth/statistics.cc.pre
index e807ff1..e8f7cc1 100644
--- a/src/bin/auth/statistics.cc.pre
+++ b/src/bin/auth/statistics.cc.pre
@@ -42,8 +42,8 @@ namespace {
/// \param trees isc::data::ElementPtr to be filled in; caller has ownership of
/// isc::data::ElementPtr
///
-/// Note: This function clears all counters to send incremental/differential
-/// values. Minus integer values indicate increments.
+/// Note: This function clears all counters to send differential values.
+/// Negative integer values indicate differences in statistics messages.
void
fillNodes(Counter& counter,
const struct isc::auth::statistics::CounterSpec type_tree[],
diff --git a/src/bin/auth/tests/statistics_unittest.cc.pre b/src/bin/auth/tests/statistics_unittest.cc.pre
index d02a700..8109690 100644
--- a/src/bin/auth/tests/statistics_unittest.cc.pre
+++ b/src/bin/auth/tests/statistics_unittest.cc.pre
@@ -475,7 +475,7 @@ TEST_F(CountersTest, incrementRcode) {
std::map<std::string, int> expect;
// Test all rcodes (NOERROR..BADVERS)
- int count_all = 0, count_rcode_other = 0, count_ednsbadver = 0;
+ int count_rcode_other = 0, count_ednsbadver = 0;
for (uint16_t i = Rcode::NOERROR().getCode(),
e = Rcode::BADVERS().getCode();
i <= e;
diff --git a/src/bin/stats/stats.py.in b/src/bin/stats/stats.py.in
index 5eb65d4..7ab0815 100755
--- a/src/bin/stats/stats.py.in
+++ b/src/bin/stats/stats.py.in
@@ -149,7 +149,7 @@ def merge_oldnew(old, new):
at same name or same id. Both old data and new data should be same
data type. This method returns the merged result.
Additonally, this function converts incremental data into counter
- values. Minus integer values are treated as increments..
+ values. Negative integer values are treated as differences.
"""
# If the first arg is dict or list type, two values
# would be merged
diff --git a/src/lib/statistics/counter.h b/src/lib/statistics/counter.h
index 2f0d8f7..5c7aa78 100644
--- a/src/lib/statistics/counter.h
+++ b/src/lib/statistics/counter.h
@@ -82,7 +82,7 @@ public:
/// \param type %Counter item to get the value of
///
/// \throw isc::OutOfRange \a type is invalid
- const Counter::Value getClear(const Counter::Type& type) {
+ Counter::Value getClear(const Counter::Type& type) {
if (type >= counters_.size()) {
isc_throw(isc::OutOfRange, "Counter type is out of range");
}
More information about the bind10-changes
mailing list