BIND 10 trac1555, updated. 6b65ea8a618d32efcdc0697cf0acc534b6f13404 [1555] Minor: added a todo comment.
BIND 10 source code commits
bind10-changes at lists.isc.org
Fri Jul 19 11:14:20 UTC 2013
The branch, trac1555 has been updated
via 6b65ea8a618d32efcdc0697cf0acc534b6f13404 (commit)
from 0d4abba272e2e77132b374a657aa96f65505f26c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 6b65ea8a618d32efcdc0697cf0acc534b6f13404
Author: Marcin Siodelski <marcin at isc.org>
Date: Fri Jul 19 13:14:02 2013 +0200
[1555] Minor: added a todo comment.
-----------------------------------------------------------------------
Summary of changes:
src/bin/dhcp4/dhcp4_srv.cc | 2 ++
src/bin/dhcp6/dhcp6_srv.cc | 2 ++
2 files changed, 4 insertions(+)
-----------------------------------------------------------------------
diff --git a/src/bin/dhcp4/dhcp4_srv.cc b/src/bin/dhcp4/dhcp4_srv.cc
index bc5a4d6..a9f0a50 100644
--- a/src/bin/dhcp4/dhcp4_srv.cc
+++ b/src/bin/dhcp4/dhcp4_srv.cc
@@ -852,6 +852,8 @@ Dhcpv4Srv::openActiveSockets(const uint16_t port,
}
// Let's reopen active sockets. openSockets4 will check internally whether
// sockets are marked active or inactive.
+ // @todo Optimization: we should not reopen all sockets but rather select
+ // those that have been affected by the new configuration.
if (!IfaceMgr::instance().openSockets4(port, use_bcast)) {
LOG_WARN(dhcp4_logger, DHCP4_NO_SOCKETS_OPEN);
}
diff --git a/src/bin/dhcp6/dhcp6_srv.cc b/src/bin/dhcp6/dhcp6_srv.cc
index 30eff1e..f6991ec 100644
--- a/src/bin/dhcp6/dhcp6_srv.cc
+++ b/src/bin/dhcp6/dhcp6_srv.cc
@@ -1133,6 +1133,8 @@ Dhcpv6Srv::openActiveSockets(const uint16_t port) {
}
// Let's reopen active sockets. openSockets6 will check internally whether
// sockets are marked active or inactive.
+ // @todo Optimization: we should not reopen all sockets but rather select
+ // those that have been affected by the new configuration.
if (!IfaceMgr::instance().openSockets6(port)) {
LOG_WARN(dhcp6_logger, DHCP6_NO_SOCKETS_OPEN);
}
More information about the bind10-changes
mailing list