BIND 10 master, updated. fc5e5746a148b1194f5a4d623bb96d1a8d9f085c [master] Fix missing virtual dtors and cppcheck failures in new code from merge of Trac 3008.

[BIND 10 source code commits]

The branch, master has been updated
       via  fc5e5746a148b1194f5a4d623bb96d1a8d9f085c (commit)
       via  ee4bbde1015148df78d7d5dbed07852866ba99b0 (commit)
      from  b54530b4539cec4476986442e72c047dddba7b48 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fc5e5746a148b1194f5a4d623bb96d1a8d9f085c
Author: Thomas Markwalder <tmark at isc.org>
Date:   Wed Jul 24 16:39:58 2013 -0400

    [master] Fix missing virtual dtors and cppcheck failures in
    new code from merge of Trac 3008.

commit ee4bbde1015148df78d7d5dbed07852866ba99b0
Author: Thomas Markwalder <tmark at isc.org>
Date:   Wed Jul 24 14:11:09 2013 -0400

    [master] ChangeLog entry 647 for Trac 3008.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog            |    8 ++++++++
 src/bin/d2/ncr_io.cc |    4 ++--
 src/bin/d2/ncr_io.h  |    6 ++++++
 src/bin/d2/ncr_msg.h |    2 +-
 4 files changed, 17 insertions(+), 3 deletions(-)

-----------------------------------------------------------------------
diff --git a/ChangeLog b/ChangeLog
index 91b9569..14b7f95 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+647.	[func]		tmark
+	Added initial implementation of classes for sending
+	and receiving NameChangeRequests between DHCP-DDNS
+	and its clients such as DHCP. This includes both 
+	abstract classes and a derivation which traffics 
+	requests across UDP sockets.
+	(Trac #3008, git b54530b4539cec4476986442e72c047dddba7b48)
+
 646.	[func]		stephen
 	Extended the hooks framework to add a "validate libraries" function.
 	This will be used to check libraries specified during BIND 10
diff --git a/src/bin/d2/ncr_io.cc b/src/bin/d2/ncr_io.cc
index aa3ef69..7b0ed83 100644
--- a/src/bin/d2/ncr_io.cc
+++ b/src/bin/d2/ncr_io.cc
@@ -199,7 +199,7 @@ NameChangeSender::sendNext() {
 
     // If queue isn't empty, then get one from the front. Note we leave
     // it on the front of the queue until we successfully send it.
-    if (send_queue_.size()) {
+    if (!send_queue_.empty()) {
         ncr_to_send_ = send_queue_.front();
 
        // @todo start defense timer
@@ -262,7 +262,7 @@ NameChangeSender::invokeSendHandler(const NameChangeSender::Result result) {
 
 void
 NameChangeSender::skipNext() {
-    if (send_queue_.size()) {
+    if (!send_queue_.empty()) {
         // Discards the request at the front of the queue.
         send_queue_.pop_front();
     }
diff --git a/src/bin/d2/ncr_io.h b/src/bin/d2/ncr_io.h
index 37d68c2..0b3f3fc 100644
--- a/src/bin/d2/ncr_io.h
+++ b/src/bin/d2/ncr_io.h
@@ -171,6 +171,9 @@ public:
         /// @throw This method MUST NOT throw.
         virtual void operator ()(const Result result,
                                  NameChangeRequestPtr& ncr) = 0;
+
+        virtual ~RequestReceiveHandler() {
+        }
     };
 
     /// @brief Constructor
@@ -435,6 +438,9 @@ public:
         /// @throw This method MUST NOT throw.
         virtual void operator ()(const Result result,
                                  NameChangeRequestPtr& ncr) = 0;
+
+        virtual ~RequestSendHandler(){
+        }
     };
 
     /// @brief Constructor
diff --git a/src/bin/d2/ncr_msg.h b/src/bin/d2/ncr_msg.h
index 4919f14..94fe0a4 100644
--- a/src/bin/d2/ncr_msg.h
+++ b/src/bin/d2/ncr_msg.h
@@ -105,7 +105,7 @@ public:
     }
 
     /// @brief Compares two D2Dhcids for inequality
-    bool operator!=(const D2Dhcid other) const {
+    bool operator!=(const D2Dhcid& other) const {
         return (this->bytes_ != other.bytes_);
 }