BIND 10 master, updated. c989ea1255cfb2086655c86234270b10c55efdff [master] Corrected Lease6 logical operator unit tests fail intermittently.

BIND 10 source code commits bind10-changes at lists.isc.org
Tue Jul 30 11:52:23 UTC 2013


The branch, master has been updated
       via  c989ea1255cfb2086655c86234270b10c55efdff (commit)
      from  775f572c3c6cedcd8f1985c5cf969cb18dbe2e9c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c989ea1255cfb2086655c86234270b10c55efdff
Author: Thomas Markwalder <tmark at isc.org>
Date:   Tue Jul 30 07:47:55 2013 -0400

    [master] Corrected Lease6 logical operator unit tests fail intermittently.
    
    Equality operator tests were reliant on two Lease6 structs, constructed
    back to back to have the same value for cltt_, which gets its value from
    time(NULL).  Corrected this by simple assignment to ensure they are always
    equal as the test expects.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dhcpsrv/tests/lease_mgr_unittest.cc |    4 ++++
 1 file changed, 4 insertions(+)

-----------------------------------------------------------------------
diff --git a/src/lib/dhcpsrv/tests/lease_mgr_unittest.cc b/src/lib/dhcpsrv/tests/lease_mgr_unittest.cc
index 124301a..d5535ae 100644
--- a/src/lib/dhcpsrv/tests/lease_mgr_unittest.cc
+++ b/src/lib/dhcpsrv/tests/lease_mgr_unittest.cc
@@ -487,6 +487,10 @@ TEST(Lease6, OperatorEquals) {
                                subnet_id);
     Lease6 lease2(Lease6::LEASE_IA_NA, addr, duid, iaid, 100, 200, 50, 80,
                                subnet_id);
+
+    // cltt_ constructs with time(NULL), make sure they are always equal
+    lease1.cltt_ = lease2.cltt_;
+
     EXPECT_TRUE(lease1 == lease2);
     EXPECT_FALSE(lease1 != lease2);
 



More information about the bind10-changes mailing list