BIND 10 trac2726, updated. e05af734b0416593a0978c3ab22bfd2ee1d991ed [2726] Proper return from assignment

[BIND 10 source code commits]

The branch, trac2726 has been updated
       via  e05af734b0416593a0978c3ab22bfd2ee1d991ed (commit)
       via  88ada22821235de67f0d3efa32394b83d11e3b79 (commit)
      from  e81de23719368f0fcea05d1607c2ffafb76f0359 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e05af734b0416593a0978c3ab22bfd2ee1d991ed
Author: Michal 'vorner' Vaner <vorner at vorner.cz>
Date:   Wed Jun 12 10:56:02 2013 +0200

    [2726] Proper return from assignment

commit 88ada22821235de67f0d3efa32394b83d11e3b79
Author: Michal 'vorner' Vaner <vorner at vorner.cz>
Date:   Wed Jun 12 10:50:48 2013 +0200

    [2726] Initialize an auxiliary array

-----------------------------------------------------------------------

Summary of changes:
 src/lib/datasrc/memory/domaintree.h |    8 +++++++-
 src/lib/dns/serial.h                |    5 ++++-
 2 files changed, 11 insertions(+), 2 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/memory/domaintree.h b/src/lib/datasrc/memory/domaintree.h
index 4c6199a..d6ab84f 100644
--- a/src/lib/datasrc/memory/domaintree.h
+++ b/src/lib/datasrc/memory/domaintree.h
@@ -705,7 +705,13 @@ public:
                         // XXX: meaningless initial values:
                         last_comparison_(0, 0,
                                          isc::dns::NameComparisonResult::EQUAL)
-    {}
+    {
+        // To silence cppcheck. We don't really use the values before
+        // initialization, but this is cleaner anyway.
+        for (size_t i = 0; i < RBT_MAX_LEVEL; ++i) {
+            nodes_[0] = NULL;
+        }
+    }
 
     /// \brief Copy constructor.
     ///
diff --git a/src/lib/dns/serial.h b/src/lib/dns/serial.h
index 678fb22..a3324eb 100644
--- a/src/lib/dns/serial.h
+++ b/src/lib/dns/serial.h
@@ -59,7 +59,10 @@ public:
     /// \brief Direct assignment from other Serial
     ///
     /// \param other The Serial to assign the value from
-    void operator=(const Serial& other) { value_ = other.getValue(); }
+    Serial &operator=(const Serial& other) {
+        value_ = other.getValue();
+        return (*this);
+    }
 
     /// \brief Direct assignment from value
     ///