BIND 10 trac2764, updated. 274ab7a8bd50c7d04214b97193c7461b99c2382e [2764] cleanup: removed an unused member function
BIND 10 source code commits
bind10-changes at lists.isc.org
Wed Mar 6 22:24:15 UTC 2013
The branch, trac2764 has been updated
via 274ab7a8bd50c7d04214b97193c7461b99c2382e (commit)
via b48b9c7e0d0b51d399f248cb3387dbae770d157e (commit)
from dd41cb13ce276c055af55e486404773dfbf31154 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 274ab7a8bd50c7d04214b97193c7461b99c2382e
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Mar 6 14:23:48 2013 -0800
[2764] cleanup: removed an unused member function
it was a leftover from an intermediate attempt.
commit b48b9c7e0d0b51d399f248cb3387dbae770d157e
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed Mar 6 14:21:49 2013 -0800
[2764] use x % 8 instead of x & 7 to check x is a multiple of 8
assuming the compiler optimizes the former (more understandable but
possibly less efficient) to the latter (less understandable but
efficient).
-----------------------------------------------------------------------
Summary of changes:
src/lib/util/encode/base_n.cc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/util/encode/base_n.cc b/src/lib/util/encode/base_n.cc
index f37ebfc..f5f930a 100644
--- a/src/lib/util/encode/base_n.cc
+++ b/src/lib/util/encode/base_n.cc
@@ -236,7 +236,6 @@ public:
bool operator==(const DecodeNormalizer& other) const {
return (base_ == other.base_);
}
- bool allDecoded() const { return (base_ == base_end_); }
private:
const char base_zero_code_;
string::const_iterator base_;
@@ -378,7 +377,7 @@ BaseNTransformer<BitsPerChunk, BaseZeroCode, Encoder, Decoder>::decode(
// Number of bits of the conversion result including padding must be
// a multiple of 8; otherwise the decoder reaches the end of input
// with some incomplete bits of data, which is invalid.
- if (((char_count * BitsPerChunk) & 7) != 0) {
+ if (((char_count * BitsPerChunk) % 8) != 0) {
throw IncompleteBaseInput(); // catch this immediately below
}
} catch (const IncompleteBaseInput&) {
More information about the bind10-changes
mailing list