BIND 10 trac2789, updated. c5f8c4c31d08049b5b8b1e7ab43011d62293f18b [2789] Removed the private member, Pool6::prefix_len_. It was created to support prefix delegation which has not been designed yet.
BIND 10 source code commits
bind10-changes at lists.isc.org
Mon Mar 25 11:33:28 UTC 2013
The branch, trac2789 has been updated
via c5f8c4c31d08049b5b8b1e7ab43011d62293f18b (commit)
from 0eb1e5059c26a083708f6d765035aba8aa4c6d2d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c5f8c4c31d08049b5b8b1e7ab43011d62293f18b
Author: Thomas Markwalder <tmark at isc.org>
Date: Mon Mar 25 07:30:49 2013 -0400
[2789] Removed the private member, Pool6::prefix_len_. It was created
to support prefix delegation which has not been designed yet.
-----------------------------------------------------------------------
Summary of changes:
src/lib/dhcpsrv/pool.cc | 9 ++++-----
src/lib/dhcpsrv/pool.h | 3 ---
2 files changed, 4 insertions(+), 8 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/dhcpsrv/pool.cc b/src/lib/dhcpsrv/pool.cc
index 7b8a4ea..746bd25 100644
--- a/src/lib/dhcpsrv/pool.cc
+++ b/src/lib/dhcpsrv/pool.cc
@@ -64,7 +64,7 @@ Pool4::Pool4(const isc::asiolink::IOAddress& prefix,
Pool6::Pool6(Pool6Type type, const isc::asiolink::IOAddress& first,
const isc::asiolink::IOAddress& last)
- :Pool(first, last), type_(type), prefix_len_(0) {
+ :Pool(first, last), type_(type) {
// check if specified address boundaries are sane
if (!first.isV6() || !last.isV6()) {
@@ -95,16 +95,15 @@ Pool6::Pool6(Pool6Type type, const isc::asiolink::IOAddress& first,
Pool6::Pool6(Pool6Type type, const isc::asiolink::IOAddress& prefix,
uint8_t prefix_len)
:Pool(prefix, IOAddress("::")),
- type_(type), prefix_len_(prefix_len) {
+ type_(type) {
// check if the prefix is sane
if (!prefix.isV6()) {
isc_throw(BadValue, "Invalid Pool6 address boundaries: not IPv6");
}
- // check if the prefix length is sane (we use the member variable only
- // for silencing some compilers; see #2705 and #2789).
- if (prefix_len_ == 0 || prefix_len_ > 128) {
+ // check if the prefix length is sane
+ if (prefix_len == 0 || prefix_len > 128) {
isc_throw(BadValue, "Invalid prefix length");
}
diff --git a/src/lib/dhcpsrv/pool.h b/src/lib/dhcpsrv/pool.h
index e8dc3e3..73c5dc4 100644
--- a/src/lib/dhcpsrv/pool.h
+++ b/src/lib/dhcpsrv/pool.h
@@ -168,9 +168,6 @@ private:
/// @brief defines a pool type
Pool6Type type_;
- /// @brief prefix length
- /// used by TYPE_PD only (zeroed for other types)
- uint8_t prefix_len_;
};
/// @brief a pointer an IPv6 Pool
More information about the bind10-changes
mailing list