BIND 10 trac2850_2, updated. 2b96d4487c517ab209a1ca5fce4af877fecae0a7 [2850] Make ZoneTableSegmentLocal::reset() throw NotImplemented exception
BIND 10 source code commits
bind10-changes at lists.isc.org
Fri May 3 01:04:44 UTC 2013
The branch, trac2850_2 has been updated
via 2b96d4487c517ab209a1ca5fce4af877fecae0a7 (commit)
from 79fe8bd49de676e941f804350bde4115ab454124 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 2b96d4487c517ab209a1ca5fce4af877fecae0a7
Author: Mukund Sivaraman <muks at isc.org>
Date: Fri May 3 06:00:19 2013 +0530
[2850] Make ZoneTableSegmentLocal::reset() throw NotImplemented exception
-----------------------------------------------------------------------
Summary of changes:
src/lib/datasrc/memory/zone_table_segment_local.cc | 4 +++-
src/lib/datasrc/memory/zone_table_segment_local.h | 4 ++--
.../tests/memory/zone_table_segment_unittest.cc | 10 ++++++----
3 files changed, 11 insertions(+), 7 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/memory/zone_table_segment_local.cc b/src/lib/datasrc/memory/zone_table_segment_local.cc
index dbcb54f..7bafa11 100644
--- a/src/lib/datasrc/memory/zone_table_segment_local.cc
+++ b/src/lib/datasrc/memory/zone_table_segment_local.cc
@@ -41,7 +41,9 @@ void
ZoneTableSegmentLocal::reset(MemorySegmentOpenMode,
isc::data::ConstElementPtr)
{
- // This method doesn't do anything in this implementation.
+ isc_throw(isc::NotImplemented,
+ "ZoneTableSegmentLocal::reset() is not implemented and "
+ "should not be used.");
}
// After more methods' definitions are added here, it would be a good
diff --git a/src/lib/datasrc/memory/zone_table_segment_local.h b/src/lib/datasrc/memory/zone_table_segment_local.h
index 6430d2a..cbb3b27 100644
--- a/src/lib/datasrc/memory/zone_table_segment_local.h
+++ b/src/lib/datasrc/memory/zone_table_segment_local.h
@@ -61,9 +61,9 @@ public:
return (true);
}
- /// \brief This method currently doesn't do anything.
+ /// \brief This method is not implemented.
///
- /// \c mode and \c params args are currently ignored.
+ /// \throw isc::NotImplemented
virtual void reset(MemorySegmentOpenMode mode,
isc::data::ConstElementPtr params);
diff --git a/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc b/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
index d8d5d06..8afc1ac 100644
--- a/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
+++ b/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
@@ -52,10 +52,12 @@ TEST_F(ZoneTableSegmentTest, create) {
}
TEST_F(ZoneTableSegmentTest, reset) {
- // reset() currently doesn't do anything in a local segment. But
- // test the API.
- ztable_segment_->reset(ZoneTableSegment::CREATE,
- Element::fromJSON("{}"));
+ // reset() should throw that it's not implemented so that any
+ // accidental calls are found out.
+ EXPECT_THROW({
+ ztable_segment_->reset(ZoneTableSegment::CREATE,
+ Element::fromJSON("{}"));
+ }, isc::NotImplemented);
}
// Helper function to check const and non-const methods.
More information about the bind10-changes
mailing list