BIND 10 trac2355, updated. 36f7b7fa7bddd07da90c9346d5d62dbed77c2a49 [2355] Added logic to bypass large value test for Uint32BitParser on 32-bit platforms.

BIND 10 source code commits bind10-changes at lists.isc.org
Tue May 7 13:23:06 UTC 2013


The branch, trac2355 has been updated
       via  36f7b7fa7bddd07da90c9346d5d62dbed77c2a49 (commit)
      from  aedbd11c6780fb36fbaa8c6c8c4521caf24fa5b4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 36f7b7fa7bddd07da90c9346d5d62dbed77c2a49
Author: Thomas Markwalder <tmark at isc.org>
Date:   Tue May 7 09:22:02 2013 -0400

    [2355] Added logic to bypass large value test for Uint32BitParser on 32-bit
    platforms.

-----------------------------------------------------------------------

Summary of changes:
 src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

-----------------------------------------------------------------------
diff --git a/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc b/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
index fe30365..687ef92 100644
--- a/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
+++ b/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
@@ -163,10 +163,13 @@ TEST_F(DhcpParserTest, uint32ParserTest) {
     ElementPtr int_element = Element::create(-1);
     EXPECT_THROW(parser.build(int_element), isc::BadValue);
 
-    // Verify that parser with rejects too large a value.
-    long max = (long)(std::numeric_limits<uint32_t>::max()) + 1;
-    int_element->setValue((long)(max));
-    EXPECT_THROW(parser.build(int_element), isc::BadValue);
+    // Verify that parser with rejects too large a value provided we are on 
+    // 64-bit platform. 
+    if (sizeof(long) > sizeof(uint32_t)) {
+        long max = (long)(std::numeric_limits<uint32_t>::max()) + 1;
+        int_element->setValue(max);
+        EXPECT_THROW(parser.build(int_element), isc::BadValue);
+    }
 
     // Verify that parser will build with value of zero.
     int test_value = 0;



More information about the bind10-changes mailing list