BIND 10 trac2851, updated. 654ec49fc5f8976cc6567b31ab8277d392f79b76 [2851] added missing parameter description.
BIND 10 source code commits
bind10-changes at lists.isc.org
Wed May 8 22:47:23 UTC 2013
The branch, trac2851 has been updated
via 654ec49fc5f8976cc6567b31ab8277d392f79b76 (commit)
via c65fde7c57736e089aa9d83f82d340d7dfb167e2 (commit)
via d4a8366000c44fe71b70dcee0615d38253b4f932 (commit)
via 4d67c32a6d5ea8a09f9a9dc995b33619f56db5fd (commit)
from 2cb89753827b015cd183fff26b52e7c28154727f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 654ec49fc5f8976cc6567b31ab8277d392f79b76
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed May 8 15:47:10 2013 -0700
[2851] added missing parameter description.
commit c65fde7c57736e089aa9d83f82d340d7dfb167e2
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed May 8 15:45:40 2013 -0700
[2851] corrected an error code in documentation (a simple typo)
commit d4a8366000c44fe71b70dcee0615d38253b4f932
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed May 8 15:41:49 2013 -0700
[2851] use "non writable" instead of read-only for a test case on this.
in some sense they mean the same thing, but technically there's a subtle
difference between them; "non writable" includes the case the cache (segment)
isn't usable at atll. calling it "read-only" is not really correct.
commit 4d67c32a6d5ea8a09f9a9dc995b33619f56db5fd
Author: JINMEI Tatuya <jinmei at isc.org>
Date: Wed May 8 15:39:19 2013 -0700
[2851] updated description of NOT_WRITABLE.
"yet" seemed to be confusing; while we could explain it more, it's probably
not much of interest for the caller anyway, and this is expected to be
a concise description. so I chose it rather simpler.
-----------------------------------------------------------------------
Summary of changes:
src/lib/datasrc/client_list.h | 9 +++++----
src/lib/datasrc/tests/client_list_unittest.cc | 6 +++---
2 files changed, 8 insertions(+), 7 deletions(-)
-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/client_list.h b/src/lib/datasrc/client_list.h
index 207b9c1..73bc2b3 100644
--- a/src/lib/datasrc/client_list.h
+++ b/src/lib/datasrc/client_list.h
@@ -352,8 +352,8 @@ public:
/// where caching is disabled for the specific
/// data source).
ZONE_NOT_FOUND, ///< Zone does not exist in this list.
- CACHE_NOT_WRITABLE, ///< The cache is not (yet) writable (and zones
- /// zones can't be loaded)
+ CACHE_NOT_WRITABLE, ///< The cache is not writable (and zones can't
+ /// be loaded)
DATASRC_NOT_FOUND, ///< Specific data source for load is specified
/// but it's not in the list
ZONE_SUCCESS ///< Zone to be cached is successfully found and
@@ -378,11 +378,12 @@ public:
/// the data source which has the given name, regardless where in the list
/// that data source is placed. Even if the given name of zone doesn't
/// exist in the data source, other data sources are not searched and
- /// this method simply returns DATASRC_NOT_FOUND in the first element
+ /// this method simply returns ZONE_NOT_FOUND in the first element
/// of the pair.
///
/// \param zone The origin of the zone to load.
- /// \param datasrc_name
+ /// \param datasrc_name If not empty, the name of the data source
+ /// to be used for loading the zone (see above).
/// \return The result has two parts. The first one is a status describing
/// if it worked or not (and in case it didn't, also why). If the
/// status is ZONE_SUCCESS, the second part contains a shared pointer
diff --git a/src/lib/datasrc/tests/client_list_unittest.cc b/src/lib/datasrc/tests/client_list_unittest.cc
index 99b4253..52f4e98 100644
--- a/src/lib/datasrc/tests/client_list_unittest.cc
+++ b/src/lib/datasrc/tests/client_list_unittest.cc
@@ -719,13 +719,13 @@ TEST_F(ListTest, badCache) {
// This test relies on the property of mapped type of cache.
TEST_F(ListTest,
#ifdef USE_SHARED_MEMORY
- cacheInReadOnlySegment
+ cacheInNonWritableSegment
#else
- DISABLED_cacheInReadOnlySegment
+ DISABLED_cacheInNonWritableSegment
#endif
)
{
- // Initializing data source with read-only zone table memory segment
+ // Initializing data source with non writable zone table memory segment
// is possible. Loading is just postponed
const ConstElementPtr elem(Element::fromJSON("["
"{"
More information about the bind10-changes
mailing list