BIND 10 trac2850_2, updated. cea0d1058d5b96e616ce8f71afd0b45a1f81b103 [2850] Add a test for clear() on an uninitialized segment

BIND 10 source code commits bind10-changes at lists.isc.org
Thu May 9 08:51:34 UTC 2013


The branch, trac2850_2 has been updated
       via  cea0d1058d5b96e616ce8f71afd0b45a1f81b103 (commit)
      from  3ebd4b039b2596328c1c112398a9e629c9a73001 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cea0d1058d5b96e616ce8f71afd0b45a1f81b103
Author: Mukund Sivaraman <muks at isc.org>
Date:   Thu May 9 14:20:51 2013 +0530

    [2850] Add a test for clear() on an uninitialized segment

-----------------------------------------------------------------------

Summary of changes:
 .../memory/zone_table_segment_mapped_unittest.cc   |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

-----------------------------------------------------------------------
diff --git a/src/lib/datasrc/tests/memory/zone_table_segment_mapped_unittest.cc b/src/lib/datasrc/tests/memory/zone_table_segment_mapped_unittest.cc
index 9164e10..762067c 100644
--- a/src/lib/datasrc/tests/memory/zone_table_segment_mapped_unittest.cc
+++ b/src/lib/datasrc/tests/memory/zone_table_segment_mapped_unittest.cc
@@ -375,6 +375,21 @@ TEST_F(ZoneTableSegmentMappedTest, resetReadOnly) {
                  MemorySegmentError);
 }
 
+TEST_F(ZoneTableSegmentMappedTest, clearUninitialized) {
+    // Clearing a segment that has not been reset() is a nop, as clear()
+    // returns it to a fresh uninitialized state anyway.
+    EXPECT_NO_THROW(ztable_segment_->clear());
+
+    // The following should still throw, because the segment has not
+    // been successfully reset() yet.
+    EXPECT_THROW(ztable_segment_->getHeader(), isc::InvalidOperation);
+    EXPECT_THROW(ztable_segment_->getMemorySegment(), isc::InvalidOperation);
+
+    // isWritable() must still return false, because the segment has not
+    // been successfully reset() yet.
+    EXPECT_FALSE(ztable_segment_->isWritable());
+}
+
 TEST_F(ZoneTableSegmentMappedTest, clear) {
     // First, open an underlying mapped file in read+write mode (doesn't
     // exist yet)



More information about the bind10-changes mailing list